r100502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100501‎ | r100502 | r100503 >
Date:17:01, 22 October 2011
Author:robin
Status:resolved
Tags:
Comment:
(bug 31410) ArticleFeedback widget displays at top of page in cologneblue [and nostalgia] skin

There was already an exception for the standard skin which has a similar layout where the catlinks are at the top of the page
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -327,7 +327,7 @@
328328
329329 // Put on bottom of article before #catlinks (if it exists)
330330 // Except in Classic, which has #catlinks above the article but inside content-div.
331 -if ( $( '#catlinks' ).length && mw.config.get( 'skin' ) != 'standard' ) {
 331+if ( $( '#catlinks' ).length && !mw.config.get( 'skin' ) in ['standard', 'cologneblue', 'nostalgia'] ) {
332332 $aftDiv.insertBefore( '#catlinks' );
333333 } else {
334334 // CologneBlue, Nostalgia, ...
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
@@ -25,8 +25,6 @@
2626 && mw.util.getParamValue( 'redirect' ) != 'no'
2727 // Not viewing the printable version
2828 && mw.util.getParamValue( 'printable' ) != 'yes'
29 - // Not using CologneBlue skin (see bug 31410)
30 - && mw.config.get( 'skin' ) != 'cologneblue'
3129 ) {
3230 // Assign a tracking bucket using options from wgArticleFeedbackTracking
3331 mw.user.bucket(

Follow-up revisions

RevisionCommit summaryAuthorDate
r100503follow-up r100502: this works (I don't know much Javascript/jQuery :p)robin17:17, 22 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99096Temporarily disable the AFT widget in the cologneblue skin pending resolution...catrope13:05, 6 October 2011

Status & tagging log