r100456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100455‎ | r100456 | r100457 >
Date:21:42, 21 October 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:
Comment:
Reallocating fields in forms: payment_method. Adding fields: payment_submethod. Removing fields: process, transaction_type (transaction_type is now payment_method).
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/Form.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/Form.php
@@ -359,8 +359,11 @@
360360 'email-opt' => $this->form_data['email-opt'],
361361 'size' => $this->form_data['size'],
362362 'premium_language' => $this->form_data['premium_language'],
363 - 'process' => isset( $this->form_data['process'] ) ? $this->form_data['process'] : 'CreditCard',
364 - 'payment_method' => 'processed',
 363+ // process has been disabled - may no longer be needed.
 364+ //'process' => isset( $this->form_data['process'] ) ? $this->form_data['process'] : 'CreditCard',
 365+ // payment_method is no longer set to: processed
 366+ 'payment_method' => isset( $this->form_data['payment_method'] ) ? $this->form_data['payment_method'] : '',
 367+ 'payment_submethod' => isset( $this->form_data['payment_submethod'] ) ? $this->form_data['payment_submethod'] : '',
365368 'token' => $this->form_data['token'],
366369 'order_id' => $this->form_data['order_id'],
367370 'i_order_id' => $this->form_data['i_order_id'],
@@ -370,7 +373,6 @@
371374 'action' => $this->form_data['action'],
372375 'owa_session' => $this->form_data['owa_session'],
373376 'owa_ref' => $this->form_data['owa_ref'],
374 - 'transaction_type' => isset( $this->form_data['transaction_type'] ) ? $this->form_data['transaction_type'] : '',
375377 );
376378 }
377379

Follow-up revisions

RevisionCommit summaryAuthorDate
r100458Added payment_submethod, removed test_string and transaction_typejpostlethwaite21:50, 21 October 2011
r100459Removed check for payment_method == processed. payment_method has been reallo...jpostlethwaite21:52, 21 October 2011
r100460Changed $transaction_groups to $payment_methods. Changed $transaction_types t...jpostlethwaite21:56, 21 October 2011
r100461Changed $transaction_groups to $payment_methods. Changed $transaction_types t...jpostlethwaite21:59, 21 October 2011
r100462Changed $transactionType to $payment_method. Added $result parameter to execu...jpostlethwaite22:00, 21 October 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   21:43, 21 October 2011

This is the beginning of a code update. Please see follow ups.

#Comment by Jpostlethwaite (talk | contribs)   22:33, 21 October 2011

Everything has been committed for this code update. Ready for review.

Status & tagging log