r100458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100457‎ | r100458 | r100459 >
Date:21:50, 21 October 2011
Author:jpostlethwaite
Status:ok
Tags:
Comment:
Added payment_submethod, removed test_string and transaction_type
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/DonationData.php
@@ -58,6 +58,7 @@
5959 'cvv' => $wgRequest->getText( 'cvv' ),
6060 'currency' => $wgRequest->getText( 'currency_code' ),
6161 'payment_method' => $wgRequest->getText( 'payment_method' ),
 62+ 'payment_submethod' => $wgRequest->getText( 'payment_submethod', null ), // Used by GlobalCollect for payment types
6263 'order_id' => $wgRequest->getText( 'order_id', null ), //as far as I know, this won't actually ever pull anything back.
6364 'i_order_id' => $wgRequest->getText( 'i_order_id', null ), //internal id for each contribution attempt
6465 'numAttempt' => $wgRequest->getVal( 'numAttempt', 0 ),
@@ -70,7 +71,8 @@
7172 'comment-option' => $wgRequest->getText( 'comment-option' ),
7273 'comment' => $wgRequest->getText( 'comment' ),
7374 'email-opt' => $wgRequest->getText( 'email-opt' ),
74 - 'test_string' => $wgRequest->getText( 'process' ), // for showing payflow string during testing
 75+ // test_string has been disabled - may no longer be needed.
 76+ //'test_string' => $wgRequest->getText( 'process' ), // for showing payflow string during testing
7577 '_cache_' => $wgRequest->getText( '_cache_', null ),
7678 'token' => $wgRequest->getText( 'token', null ),
7779 'contribution_tracking_id' => $wgRequest->getText( 'contribution_tracking_id' ),
@@ -79,7 +81,6 @@
8082 'gateway' => $wgRequest->getText( 'gateway' ), //likely to be reset shortly by setGateway();
8183 'owa_session' => $wgRequest->getText( 'owa_session', null ),
8284 'owa_ref' => $wgRequest->getText( 'owa_ref', null ),
83 - 'transaction_type' => $wgRequest->getText( 'transaction_type', null ), // Used by GlobalCollect for payment types
8485 );
8586 if ( !$wgRequest->wasPosted() ) {
8687 $this->setVal( 'posted', false );
@@ -150,6 +151,7 @@
151152 'cvv' => '001',
152153 'currency' => 'USD',
153154 'payment_method' => $wgRequest->getText( 'payment_method' ),
 155+ 'payment_submethod' => $wgRequest->getText( 'payment_submethod' ),
154156 'order_id' => '1234567890',
155157 'i_order_id' => '1234567890',
156158 'numAttempt' => 0,
@@ -161,7 +163,8 @@
162164 'comment-option' => $wgRequest->getText( 'comment-option' ),
163165 'comment' => $wgRequest->getText( 'comment' ),
164166 'email-opt' => $wgRequest->getText( 'email-opt' ),
165 - 'test_string' => $wgRequest->getText( 'process' ),
 167+ // test_string has been disabled - may no longer be needed.
 168+ //'test_string' => $wgRequest->getText( 'process' ),
166169 'token' => '',
167170 'contribution_tracking_id' => $wgRequest->getText( 'contribution_tracking_id' ),
168171 'data_hash' => $wgRequest->getText( 'data_hash' ),
@@ -169,7 +172,6 @@
170173 'gateway' => 'payflowpro',
171174 'owa_session' => $wgRequest->getText( 'owa_session', null ),
172175 'owa_ref' => 'http://localhost/defaultTestData',
173 - 'transaction_type' => '', // Used by GlobalCollect for payment types
174176 );
175177 }
176178 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100456Reallocating fields in forms: payment_method. Adding fields: payment_submetho...jpostlethwaite21:42, 21 October 2011

Status & tagging log