r100153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100152‎ | r100153 | r100154 >
Date:20:19, 18 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed missing review form for diffs against non-stable but accepted revs with diffonly=1
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggablePageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggablePageView.php
@@ -1079,9 +1079,9 @@
10801080 }
10811081 # Get the revision being displayed
10821082 $rev = false;
1083 - if ( $this->reviewFormRev ) {
 1083+ if ( $this->reviewFormRev ) { // diff
10841084 $rev = $this->reviewFormRev; // $newRev for diffs stored here
1085 - } elseif ( $this->out->getRevisionId() ) {
 1085+ } elseif ( $this->out->getRevisionId() ) { // page view
10861086 $rev = Revision::newFromId( $this->out->getRevisionId() );
10871087 }
10881088 # Build the review form as needed
@@ -1387,6 +1387,9 @@
13881388 return true;
13891389 }
13901390 $srev = $this->article->getStableRev();
 1391+ if ( $srev && $this->isReviewableDiff ) {
 1392+ $this->reviewFormRev = $newRev;
 1393+ }
13911394 # Check if this is a diff-to-stable. If so:
13921395 # (a) prompt reviewers to review the changes
13931396 # (b) list template/file changes if only includes are pending
@@ -1395,7 +1398,6 @@
13961399 && !$this->article->stableVersionIsSynced() ) // pending changes
13971400 {
13981401 $changeText = '';
1399 - $this->reviewFormRev = $newRev;
14001402 $changeList = array();
14011403 # Page not synced only due to includes?
14021404 if ( !$this->article->revsArePending() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103190REL1_18 MFT r100153reedy16:36, 15 November 2011
r1031911.18wmf1 Merge r103190 which is a manual merge of r100153reedy16:38, 15 November 2011

Comments

#Comment by Reedy (talk | contribs)   23:26, 9 November 2011

treeconflict much?

#Comment by Reedy (talk | contribs)   23:32, 9 November 2011

Will need merging manually, file doesn't exist in 1.18wmf1

#Comment by Aaron Schulz (talk | contribs)   23:47, 9 November 2011

Ah, the file/class was renamed from FlaggedPageView.

Status & tagging log