r103191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103190‎ | r103191 | r103192 >
Date:16:38, 15 November 2011
Author:reedy
Status:ok
Tags:
Comment:
1.18wmf1 Merge r103190 which is a manual merge of r100153
Modified paths:
  • /branches/wmf/1.18wmf1/extensions (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -1076,9 +1076,9 @@
10771077 }
10781078 # Get the revision being displayed
10791079 $rev = false;
1080 - if ( $this->reviewFormRev ) {
 1080+ if ( $this->reviewFormRev ) { //diff
10811081 $rev = $this->reviewFormRev; // $newRev for diffs stored here
1082 - } elseif ( $this->out->getRevisionId() ) {
 1082+ } elseif ( $this->out->getRevisionId() ) { // page view
10831083 $rev = Revision::newFromId( $this->out->getRevisionId() );
10841084 }
10851085 # Build the review form as needed
@@ -1377,6 +1377,9 @@
13781378 return true;
13791379 }
13801380 $srev = $this->article->getStableRev();
 1381+ if ( $srev && $this->isReviewableDiff ) {
 1382+ $this->reviewFormRev = $newRev;
 1383+ }
13811384 # Check if this is a diff-to-stable. If so:
13821385 # (a) prompt reviewers to review the changes
13831386 # (b) list template/file changes if only includes are pending
@@ -1385,7 +1388,6 @@
13861389 && !$this->article->stableVersionIsSynced() ) // pending changes
13871390 {
13881391 $changeDiv = '';
1389 - $this->reviewFormRev = $newRev;
13901392 $changeList = array();
13911393 # Page not synced only due to includes?
13921394 if ( !$this->article->revsArePending() ) {
Property changes on: branches/wmf/1.18wmf1/extensions/FlaggedRevs
___________________________________________________________________
Modified: svn:mergeinfo
13931395 Merged /branches/REL1_18/extensions/FlaggedRevs:r103190
Property changes on: branches/wmf/1.18wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
13941396 Merged /branches/REL1_18/extensions:r103190

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100153Fixed missing review form for diffs against non-stable but accepted revs with...aaron20:19, 18 October 2011
r103190REL1_18 MFT r100153reedy16:36, 15 November 2011

Status & tagging log