r99934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99933‎ | r99934 | r99935 >
Date:23:48, 15 October 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Drop IE5.x support
-- except for fixalpha/IE5.5 (iirc this is for IE6 as well)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/skins/Chick.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/IE50Fixes.css (deleted) (history)
  • /trunk/phase3/skins/chick/IE55Fixes.css (deleted) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (deleted) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/IE50Fixes.css
@@ -1,74 +0,0 @@
2 -/**
3 - * IE5.0 Fix Stylesheet
4 - */
5 -
6 -#column-content {
7 - margin: 0 !important;
8 - float: none;
9 -}
10 -#column-content #content {
11 - margin-top: 3em;
12 - height: 1%;
13 -}
14 -#column-one {
15 - position: absolute;
16 - overflow: visible;
17 - top: 0;
18 - left: 0;
19 - z-index: 3;
20 -}
21 -#footer {
22 - margin: 0 0 0 13.6em;
23 -}
24 -
25 -/* IE 5 & 5.5 interpret keyword sizes one off */
26 -body {
27 - font-size: xx-small;
28 -}
29 -
30 -/* the edit tabs */
31 -#p-cactions li {
32 - float: left;
33 - padding-top: 0;
34 - padding-bottom: 0 !important;
35 - height: 0.9em;
36 -}
37 -#p-cactions li a {
38 - display: block;
39 - padding-bottom: 0.045em;
40 -}
41 -#p-cactions li.selected a {
42 - padding-bottom: 0.17em;
43 -}
44 -#p-cactions li a:hover {
45 - padding-bottom: 0.17em;
46 -}
47 -
48 -/* IE5.0 doesn't like the background icon for external links and user */
49 -.link-external,
50 -.external {
51 - background: none;
52 - padding: 0;
53 -}
54 -#p-personal ul {
55 - float: right;
56 -}
57 -#p-personal li {
58 - float: left;
59 -}
60 -li#pt-userpage,
61 -li#pt-anonuserpage,
62 -li#pt-login,
63 -li#pt-logout {
64 - background: none;
65 - padding-left: none;
66 -}
67 -.visualClear {
68 - width: 100%;
69 - height: 0;
70 - padding: 0;
71 - margin: 0;
72 -}
73 -#firstHeading {
74 - margin-bottom: 0.3em;
75 -}
Index: trunk/phase3/skins/chick/IE55Fixes.css
@@ -1,82 +0,0 @@
2 -/* IE5.5/win- only fixes */
3 -
4 -#column-content {
5 - float: none;
6 - margin-left: 0;
7 - height: 1%;
8 -}
9 -#column-content #content {
10 - position: relative;
11 - z-index: 5;
12 - margin-left: 12.2em;
13 - margin-top: 3em;
14 - height: 1%;
15 -}
16 -#column-one {
17 - position: absolute;
18 - top: 0;
19 - left: 0;
20 - z-index: 4;
21 - width: 100%;
22 -}
23 -#footer {
24 - margin-left: 13.6em;
25 - border-left: 1px solid #fabd23;
26 -}
27 -
28 -#p-personal {
29 - padding-bottom: 0.1em;
30 -}
31 -
32 -body {
33 - font-size: xx-small;
34 -}
35 -
36 -#p-cactions {
37 - width: 76% !important;
38 - z-index: 3 !important;
39 - float: none;
40 -}
41 -#p-cactions li {
42 - padding-bottom: 0 !important;
43 - border: none;
44 - background-color: transparent;
45 - cursor: default;
46 - float: none !important;
47 -}
48 -#p-cactions li a {
49 - display: inline-block !important;
50 - vertical-align: top;
51 - padding-bottom: 0;
52 - border: solid #aaa;
53 - border-width: 1px 1px 0;
54 -}
55 -#p-cactions li.selected a {
56 - border-color: #fabd23;
57 - padding-bottom: 0.17em;
58 -}
59 -#p-cactions li a:hover {
60 - padding-bottom: 0.17em;
61 -}
62 -.portlet {
63 - overflow:hidden;
64 -}
65 -#bodyContent a.external {
66 - background: url(external.png) center right no-repeat;
67 - padding-right: 13px;
68 -}
69 -/* show the hand */
70 -#p-logo a,
71 -#p-logo a:hover {
72 - cursor: pointer;
73 -}
74 -.visualClear {
75 - width:90%;
76 - height: 1px;
77 - padding:0;
78 - margin:0;
79 -}
80 -
81 -#editform {
82 - width: 100%;
83 -}
Index: trunk/phase3/skins/monobook/IE50Fixes.css
@@ -1,75 +0,0 @@
2 -/*
3 -** IE5.0 Fix Stylesheet
4 -*/
5 -
6 -div#column-content {
7 - margin: 0 !important;
8 - float: none;
9 -}
10 -div#column-content #content {
11 - margin-top: 3em;
12 - height: 1%;
13 -}
14 -div#column-one {
15 - position: absolute;
16 - overflow: visible;
17 - top: 0;
18 - left: 0;
19 - z-index: 3;
20 -}
21 -div#footer {
22 - margin: 0 0 0 13.6em;
23 -}
24 -
25 -/* IE 5 & 5.5 interpret keyword sizes one off */
26 -body {
27 - font-size: xx-small;
28 -}
29 -
30 -/*
31 -** the edit tabs
32 -*/
33 -#p-cactions li {
34 - float: left;
35 - padding-top: 0;
36 - padding-bottom: 0 !important;
37 - height: 0.9em;
38 -}
39 -#p-cactions li a {
40 - display: block;
41 - padding-bottom: 0.045em;
42 -}
43 -#p-cactions li.selected a {
44 - padding-bottom: 0.17em;
45 -}
46 -#p-cactions li a:hover {
47 - padding-bottom: 0.17em;
48 -}
49 -/* 5.0 doesn't like the background icon for external links and user */
50 -.link-external,
51 -.external {
52 - background: none;
53 - padding: 0;
54 -}
55 -#p-personal ul {
56 - float: right;
57 -}
58 -#p-personal li {
59 - float: left;
60 -}
61 -li#pt-userpage,
62 -li#pt-anonuserpage,
63 -li#pt-login,
64 -li#pt-logout {
65 - background: none;
66 - padding-left: none;
67 -}
68 -.visualClear {
69 - width: 100%;
70 - height: 0;
71 - padding:0;
72 - margin: 0;
73 -}
74 -#firstHeading {
75 - margin-bottom: 0.3em;
76 -}
Index: trunk/phase3/skins/monobook/IE55Fixes.css
@@ -1,86 +0,0 @@
2 -/* IE5.5/win- only fixes */
3 -
4 -div#column-content {
5 - float: none;
6 - margin-left: 0;
7 - height: 1%;
8 -}
9 -div#column-content #content {
10 - position: relative;
11 - z-index: 5;
12 - margin-left: 12.2em;
13 - margin-top: 3em;
14 - height: 1%;
15 -}
16 -div#column-one {
17 - position: absolute;
18 - top: 0;
19 - left: 0;
20 - z-index: 4;
21 - width: 100%;
22 -}
23 -div#footer {
24 - margin-left: 13.6em;
25 - border-left: 1px solid #fabd23;
26 -}
27 -
28 -#p-personal {
29 - padding-bottom: 0.1em;
30 -}
31 -
32 -body {
33 - font-size: xx-small;
34 -}
35 -
36 -#p-cactions {
37 - width: 76% !important;
38 - z-index: 3 !important;
39 - float: none;
40 -}
41 -#p-cactions li {
42 - padding-bottom: 0 !important;
43 - border: none;
44 - background-color: transparent;
45 - cursor: default;
46 - float: none !important;
47 -}
48 -#p-cactions li a {
49 - display: inline-block !important;
50 - vertical-align: top;
51 - padding-bottom: 0;
52 - border: solid #aaa;
53 - border-width: 1px 1px 0;
54 -}
55 -#p-cactions li.selected a {
56 - border-color: #fabd23;
57 - padding-bottom: 0.17em;
58 -}
59 -#p-cactions li a:hover {
60 - padding-bottom: 0.17em;
61 -}
62 -#p-navigation a {
63 - display: inline-block;
64 - width: 100%;
65 -}
66 -.portlet {
67 - overflow: hidden;
68 -}
69 -#bodyContent a.external {
70 - background: url(external.png) center right no-repeat;
71 - padding-right: 13px;
72 -}
73 -/* show the hand */
74 -#p-logo a,
75 -#p-logo a:hover {
76 - cursor: pointer;
77 -}
78 -.visualClear {
79 - width: 90%;
80 - height: 1px;
81 - padding: 0;
82 - margin: 0;
83 -}
84 -
85 -#editform {
86 - width: 100%;
87 -}
Index: trunk/phase3/skins/Chick.php
@@ -30,8 +30,6 @@
3131 $out->addModuleStyles( 'skins.chick' );
3232
3333 // TODO: Migrate all of these to RL
34 - $out->addStyle( 'chick/IE50Fixes.css', 'screen,handheld', 'lt IE 5.5000' );
35 - $out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
3634 $out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
3735 }
3836 }
Index: trunk/phase3/skins/MonoBook.php
@@ -39,8 +39,6 @@
4040 }
4141
4242 // TODO: Migrate all of these
43 - $out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
44 - $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
4543 $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
4644 $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
4745
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -145,6 +145,9 @@
146146 populateImageSha1.php
147147 * The Client-IP header is no longer checked for when trying to resolve a client's
148148 real IP address.
 149+* Although IE5.x was already unsupported officially, stylesheets existing
 150+ exclusively for IE5.0 and IE5.5 have now been removed (were in skins 'chick'
 151+ and 'monobook').
149152
150153 == Compatibility ==
151154

Sign-offs

UserFlagDate
Hasharinspected12:31, 27 October 2011

Comments

#Comment by Raymond (talk | contribs)   17:37, 18 October 2011

Can bug 22096 be closed now?

#Comment by Krinkle (talk | contribs)   20:00, 18 October 2011

Done

Status & tagging log