r99890 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99889‎ | r99890 | r99891 >
Date:17:03, 15 October 2011
Author:erik
Status:ok (Comments)
Tags:
Comment:
1) Prefix contest configuation messages with Contests/
2) Tweak fancybox options to work well for long rules pages
3) Tweaks/fixes to UI messages
Modified paths:
  • /trunk/extensions/Contest/Contest.i18n.php (modified) (history)
  • /trunk/extensions/Contest/includes/Contest.class.php (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.signup.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.welcome.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.i18n.php
@@ -108,17 +108,17 @@
109109
110110 // Special:ContestWelcome
111111 'contest-welcome-unknown' => 'There is no contest with the provided name.',
112 - 'contest-welcome-rules' => 'In order to participate, you must agree to', // js i18n
 112+ 'contest-welcome-rules' => 'In order to participate, you are required to agree to', // js i18n
113113 'contest-welcome-rules-link' => 'the contest rules', // js i18n
114114 'contest-welcome-signup' => 'Signup now',
115 - 'contest-welcome-js-off' => 'Contest uses JavaScript for an improved interface. Your browser either does not support JavaScript or has JavaScript turned off.',
 115+ 'contest-welcome-js-off' => 'The contest user interface uses JavaScript for an improved interface. Your browser either does not support JavaScript or has JavaScript turned off.',
116116 'contest-welcome-accept-challenge' => 'Challenge Accepted',
117117
118118 'contest-welcome-select-header' => 'Select your challenge:',
119119
120120 // Special:ContestSignup & Special:ContestSubmission
121121 'contest-signup-unknown' => 'There is no contest with the provided name.',
122 - 'contest-signup-submit' => 'Signup',
 122+ 'contest-signup-submit' => 'Sign up',
123123 'contest-signup-header' => 'Please fill out the form to complete your registration for $1.',
124124 'contest-signup-email' => 'Your email address',
125125 'contest-signup-realname' => 'Your real name',
@@ -134,13 +134,13 @@
135135 'contest-signup-require-rules' => 'You need to agree to the contest rules.',
136136 'contest-signup-require-country' => 'You need to provide your country of residence.',
137137 'contest-signup-invalid-email' => 'The email address you provided is not valid.',
138 - 'contest-signup-invalid-name' => 'The name you provided is to short.',
 138+ 'contest-signup-invalid-name' => 'The name you provided is too short.',
139139 'contest-signup-require-challenge' => 'You must select a challenge.',
140140 'contest-signup-invalid-cv' => 'You entered an invalid URL.',
141141
142142 // Special:Contest
143143 'contest-contest-title' => 'Contest: $1',
144 - 'contest-contest-no-results' => 'There are no contestants to list.',
 144+ 'contest-contest-no-results' => 'There are no contestants to display.',
145145 'contest-contest-name' => 'Name',
146146 'contest-contest-status' => 'Status',
147147 'contest-contest-submissioncount' => 'Amount of participants',
@@ -288,7 +288,7 @@
289289 'contest-email-reminder-title' => 'Title for reminder emails',
290290
291291 // Special:MyContests
292 - 'contest-mycontests-toplink' => 'Text for link in the top menue (ie where watchlist and preferences are linked)',
 292+ 'contest-mycontests-toplink' => 'Text for link in the top menu (ie where watchlist and preferences are linked)',
293293 'contest-mycontests-no-contests' => 'Message indicating there are no contests for the user, displayed instead of a list.',
294294 'contest-mycontests-active-header' => 'Page header (h2)',
295295 'contest-mycontests-finished-header' => 'Page header (h2)',
Index: trunk/extensions/Contest/includes/Contest.class.php
@@ -141,12 +141,12 @@
142142 'status' => self::STATUS_DRAFT,
143143 'end' => '',
144144
145 - 'rules_page' => 'MediaWiki:',
146 - 'opportunities' => 'MediaWiki:',
147 - 'intro' => 'MediaWiki:',
 145+ 'rules_page' => 'MediaWiki:Contests/',
 146+ 'opportunities' => 'MediaWiki:Contests/',
 147+ 'intro' => 'MediaWiki:Contests/',
148148 'help' => '',
149 - 'signup_email' => 'MediaWiki:',
150 - 'reminder_email' => 'MediaWiki:',
 149+ 'signup_email' => 'MediaWiki:Contests/',
 150+ 'reminder_email' => 'MediaWiki:Contests/',
151151
152152 'submission_count' => 0,
153153 );
Index: trunk/extensions/Contest/resources/contest.special.welcome.js
@@ -28,14 +28,13 @@
2929 $rules.html( $p ).append( $div );
3030
3131 $a.fancybox( {
32 - 'width' : '75%',
33 -// 'height' : '75%',
34 -// 'autoScale' : true,
 32+ 'width' : '85%',
 33+ 'height' : '85%',
3534 'transitionIn' : 'none',
3635 'transitionOut' : 'none',
3736 'type' : 'inline',
38 -// 'autoDimensions': false
 37+ 'autoDimensions': false
3938 } );
4039 } );
4140
42 -})( window.jQuery, window.mediaWiki );
\ No newline at end of file
 41+})( window.jQuery, window.mediaWiki );
Index: trunk/extensions/Contest/resources/contest.special.signup.js
@@ -26,15 +26,14 @@
2727 $rules.closest( 'td' ).append( $div );
2828
2929 $a.fancybox( {
30 - 'width' : '75%',
31 -// 'height' : '75%',
32 -// 'autoScale' : true,
 30+ 'width' : '85%',
 31+ 'height' : '85%',
3332 'transitionIn' : 'none',
3433 'transitionOut' : 'none',
3534 'type' : 'inline',
36 -// 'autoDimensions': false
 35+ 'autoDimensions': false
3736 } );
3837
3938 } );
4039
41 -})( window.jQuery, window.mediaWiki );
\ No newline at end of file
 40+})( window.jQuery, window.mediaWiki );

Comments

#Comment by Nikerabbit (talk | contribs)   10:23, 16 October 2011

If those configuration messages are used with message handling functions, / wont work, since it has special meaning for message cache.

Status & tagging log