r99857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99856‎ | r99857 | r99858 >
Date:09:18, 15 October 2011
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
1.0.4 rel
Modified paths:
  • /trunk/extensions/Maps/INSTALL (modified) (history)
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/INSTALL
@@ -1,26 +1,40 @@
2 -[[Maps 1.0.4]]
 2+These is the install file for the Maps extension.
 3+
 4+Extension page on mediawiki.org: http://www.mediawiki.org/wiki/Extension:Maps
 5+Latest version of the install file: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Maps/INSTALL?view=co
36
4 -In order to use this version of Maps, you need to have Validator 0.3.6 installed. If you get a distribution
5 -from this page, you don't need to bother this, since Validator comes bundled with every release, and will
6 -automatically be loaded by Maps. If you get Maps from SVN trunk, or a tag, you must make sure you also get
7 -Validator.
87
9 -Once you have downloaded the code, place the 'Maps' directory within your MediaWiki 'extensions' directory.
10 -Then add the following code to your LocalSettings.php file:
 8+== Requirements ==
119
12 -# Maps
13 -require_once( "$IP/extensions/Maps/Maps.php" );
 10+Maps requires:
1411
15 -For using Google Maps or Yahoo! Maps, you must enter their API keys in the settings file. If you don't already
16 -have them, you can obtain them at the Google Maps API page and Yahoo Maps API page. Note that the Google Maps
17 -API key is required for both displaying maps AND for geocoding (and therefore also required when you use
18 -display_address with a Yahoo! Map). Also note that use of the Google Maps API is free only if your site is
19 -accessible to the public; otherwise it costs money - read the Google Maps terms of service [0] for further details.
 12+* MediaWiki 1.17 or above
 13+* PHP 5.2 or above, 5.3 or above recommended
 14+* Validator 0.4.11 or above
2015
21 -Once you have successfully installed Maps, please add your wiki to the Sites that use Maps section [1].
 16+== Download ==
2217
23 -More information can be found at [2].
 18+You can find the current version of Maps on the Google Code download page [0],
 19+as well as a list of legacy downloads [1].
2420
25 -[0] http://code.google.com/apis/maps/terms.html
26 -[1] http://www.mediawiki.org/wiki/Extension:Maps#Sites_that_use_Maps
27 -[2] http://mapping.referata.com/wiki/Maps#Installation
\ No newline at end of file
 21+[0] https://code.google.com/p/mwmaps/downloads/list
 22+[1] https://code.google.com/p/mwmaps/downloads/list?can=1
 23+
 24+You can also get the code directly from SVN. Tags can be obtained via
 25+
 26+ svn checkout http://svn.wikimedia.org/svnroot/mediawiki/tags/extensions/Maps/REL_version
 27+
 28+Where 'version' is the version number of the tag, such as 0_1
 29+(see the available tags at http://svn.wikimedia.org/svnroot/mediawiki/tags/extensions/Maps/).
 30+
 31+The latest code can be obtained from trunk:
 32+
 33+ svn checkout http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/Maps/
 34+
 35+== Installation ==
 36+
 37+Once you have downloaded the code, place the ''Maps'' directory within your MediaWiki
 38+'extensions' directory. Then add the following code to your [[Manual:LocalSettings.php|LocalSettings.php]] file:
 39+
 40+# Maps
 41+require_once( "$IP/extensions/Maps/Maps.php" );
\ No newline at end of file
Index: trunk/extensions/Maps/Maps.php
@@ -41,7 +41,7 @@
4242 die( '<b>Error:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.<br />' );
4343 }
4444
45 -define( 'Maps_VERSION', '1.0.4 alpha' );
 45+define( 'Maps_VERSION', '1.0.4' );
4646
4747 $wgExtensionCredits['parserhook'][] = array(
4848 'path' => __FILE__,
Index: trunk/extensions/Maps/RELEASE-NOTES
@@ -8,7 +8,7 @@
99
1010
1111 === Maps 1.0.4 ===
12 -(2011-0x-xx)
 12+(2011-10-15)
1313
1414 * Updated OpenLayers from 2.10 to 2.11.
1515 * Fixed bug in adding adittional markers for Google Maps v3 (mainly affecting the Semantic Maps form input).

Follow-up revisions

RevisionCommit summaryAuthorDate
r99944Follow up to r99857;jeroendedauw10:17, 16 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:59, 16 October 2011

These is?