r99839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99838‎ | r99839 | r99840 >
Date:02:08, 15 October 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r99838, fixing 2 more
Modified paths:
  • /branches/wmf/1.18wmf1/maintenance/rebuildInterwiki.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/maintenance/rebuildInterwiki.php
@@ -160,7 +160,7 @@
161161
162162 # Links to multilanguage sites
163163 foreach ( $sites as $targetSite ) {
164 - $sql .= $this->makeLink( array( $targetSite->lateral, $targetSite->getURL( 'en' ), 1 ), $first, $db );
 164+ $sql .= $this->makeLink( array( $targetSite->lateral, $targetSite->getURL( 'en', '' ), 1 ), $first, $db );
165165 }
166166
167167 # Interlanguage links to wikipedia
@@ -209,7 +209,7 @@
210210 foreach ( $sites as $targetSite ) {
211211 # Suppress link to self
212212 if ( $targetSite->suffix != $site->suffix ) {
213 - $sql .= $this->makeLink( array( $targetSite->lateral, $targetSite->getURL( $lang ), 1 ), $first, $db );
 213+ $sql .= $this->makeLink( array( $targetSite->lateral, $targetSite->getURL( $lang, '' ), 1 ), $first, $db );
214214 }
215215 }
216216

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99838Warning: Missing argument 2 for Site::getURL(), called in /home/wikipedia/com...reedy02:06, 15 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   08:09, 16 October 2011

tag for 1.18?

Status & tagging log