r99836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99835‎ | r99836 | r99837 >
Date:01:38, 15 October 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Bug 31624 - DB error on addwiki command: Column 'si_title' cannot be part of FULLTEXT index

Kill searchindex table in 1.18wmf1, we don't need/use it
Modified paths:
  • /branches/wmf/1.18wmf1/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/maintenance/tables.sql
——@@ -1090,32 +1090,7 @@
10911091 CREATE UNIQUE INDEX /*i*/wl_user ON /*_*/watchlist (wl_user, wl_namespace, wl_title);
10921092 CREATE INDEX /*i*/namespace_title ON /*_*/watchlist (wl_namespace, wl_title);
10931093
1094 -
10951094 --
1096 -CREATE TABLE /*_*/searchindex (
1097 - -- Key to page_id
1098 - si_page int unsigned NOT NULL,
1099 -
1100 - -- Munged version of title
1101 - si_title varchar(255) NOT NULL default '',
1102 -
1103 - -- Munged version of body text
1104 - si_text mediumtext NOT NULL
1105 -) ENGINE=MyISAM;
1106 -
1107 -CREATE UNIQUE INDEX /*i*/si_page ON /*_*/searchindex (si_page);
1108 -CREATE FULLTEXT INDEX /*i*/si_title ON /*_*/searchindex (si_title);
1109 -CREATE FULLTEXT INDEX /*i*/si_text ON /*_*/searchindex (si_text);
1110 -
1111 -
11121095 -- Recognized interwiki link prefixes
11131096 --
11141097 CREATE TABLE /*_*/interwiki (

Follow-up revisions

RevisionCommit summaryAuthorDate
r100467Followup r99836, just comment out the offending index...reedy22:28, 21 October 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:22, 21 October 2011

Causes bug 31867 -- installer doesn't work on 1.18wmf1 branch, making it harder to set up a test instance.

#Comment by Reedy (talk | contribs)   22:24, 21 October 2011

Easiest way to fix this, I guess, is just comment out the offending index rather than the whole table

Status & tagging log