r99827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99826‎ | r99827 | r99828 >
Date:23:09, 14 October 2011
Author:bachsau
Status:ok (Comments)
Tags:
Comment:
Easier installation: is now automaticaly set for every additional plugin.
Modified paths:
  • /trunk/extensions/ConfirmEdit/FancyCaptcha.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/MathCaptcha.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/QuestyCaptcha.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/ReCaptcha.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/ReCaptcha.php
@@ -10,10 +10,13 @@
1111 * @licence MIT/X11
1212 */
1313
14 -if( !defined( 'MEDIAWIKI' ) ) {
 14+if ( !defined( 'MEDIAWIKI' ) ) {
1515 exit;
1616 }
1717
 18+require_once dirname( __FILE__ ) . '/ConfirmEdit.php';
 19+$wgCaptchaClass = 'ReCaptcha';
 20+
1821 $wgExtensionMessagesFiles['ReCaptcha'] = dirname( __FILE__ ) . '/ReCaptcha.i18n.php';
1922
2023 require_once( 'recaptchalib.php' );
Index: trunk/extensions/ConfirmEdit/MathCaptcha.php
@@ -12,8 +12,10 @@
1313 */
1414
1515 if ( !defined( 'MEDIAWIKI' ) ) {
16 - echo( "This file is an extension to the MediaWiki software and cannot be used standalone.\n" );
17 - die( 1 );
 16+ exit;
1817 }
1918
 19+require_once dirname( __FILE__ ) . '/ConfirmEdit.php';
 20+$wgCaptchaClass = 'MathCaptcha';
 21+
2022 $wgAutoloadClasses['MathCaptcha'] = dirname( __FILE__ ) . '/MathCaptcha.class.php';
Index: trunk/extensions/ConfirmEdit/QuestyCaptcha.php
@@ -28,6 +28,9 @@
2929 exit;
3030 }
3131
 32+require_once dirname( __FILE__ ) . '/ConfirmEdit.php';
 33+$wgCaptchaClass = 'QuestyCaptcha';
 34+
3235 global $wgCaptchaQuestions;
3336 $wgCaptchaQuestions = array();
3437
Index: trunk/extensions/ConfirmEdit/FancyCaptcha.php
@@ -29,6 +29,9 @@
3030 exit;
3131 }
3232
 33+require_once dirname( __FILE__ ) . '/ConfirmEdit.php';
 34+$wgCaptchaClass = 'FancyCaptcha';
 35+
3336 global $wgCaptchaDirectory;
3437 $wgCaptchaDirectory = "$wgUploadDirectory/captcha"; // bad default :D
3538

Sign-offs

UserFlagDate
Bachsauinspected14:52, 15 October 2011
Bachsautested14:52, 15 October 2011

Comments

#Comment by 😂 (talk | contribs)   14:50, 1 December 2011

This breaks HipHop support.

#Comment by Hashar (talk | contribs)   14:07, 6 December 2011

Our doc is not really clear about that: http://www.mediawiki.org/wiki/HipHop#Interpreter and we have a lot of such occurrences in core.

I guess we will do a full pass to fix whose whenever we start working on HipHop.

So marking ok.

Status & tagging log