r99761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99760‎ | r99761 | r99762 >
Date:08:16, 14 October 2011
Author:erik
Status:ok (Comments)
Tags:
Comment:
match regexes for URL validation in JS
FIXME: both should validate against the domain config value
Modified paths:
  • /trunk/extensions/Contest/specials/SpecialMyContests.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/specials/SpecialMyContests.php
@@ -447,10 +447,10 @@
448448 // '@^https://github\.com/[a-zA-Z0-9-]+/[a-zA-Z0-9_-]+/tree/[a-zA-Z0-9]{40}$@i'
449449
450450 // Any GitHub URL
451 - '@^https://github\.com/.*$@i',
 451+ '@^https?://github\.com/.*$@i',
452452
453453 // Any Gitorious URL
454 - '@^https://(www\.)?gitorious\.org/.*$@i',
 454+ '@^https?://(www\.)?gitorious\.org/.*$@i',
455455 );
456456
457457 foreach ( $allowedPatterns as $pattern ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r99780follow up to r99761jeroendedauw17:17, 14 October 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   17:04, 14 October 2011

Right - I'll take care of the fixme.

Status & tagging log