r99680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99679‎ | r99680 | r99681 >
Date:13:43, 13 October 2011
Author:amire80
Status:ok (Comments)
Tags:
Comment:
Made the arrow point in the correct direction according to the user's language, which may be different from the wiki language.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
——@@ -1051,8 +1051,8 @@
10521052 * @return String: HTML <img> tag
10531053 */
10541054 protected function sideArrow() {
1055 - global $wgContLang;
1056 - $dir = $wgContLang->isRTL() ? 'l' : 'r';
 1055+ global $wgLang;
 1056+ $dir = $wgLang->isRTL() ? 'l' : 'r';
10571057 return $this->arrow( $dir, '+', wfMsg( 'rc-enhanced-expand' ) );
10581058 }
10591059

Follow-up revisions

RevisionCommit summaryAuthorDate
r100494MFT r99680, r100021, 100115reedy02:46, 22 October 2011
r1006231.18wmf1: MFT r99630, r99680, r100021, r100115, r100332nikerabbit17:26, 24 October 2011

Comments

#Comment by Amire80 (talk | contribs)   13:51, 13 October 2011

To test:

  1. Enter an LTR wiki (English is OK).
  2. Check "Use enhanced recent changes" in the recent changes preferences.
  3. Make several changes to the same page.
  4. Open Special:RecentChanges. Notice the triangular arrow direction near the line of the page that was edited several times.
  5. Repeat the previous step with Special:RecentChanges?uselang=he .

Status & tagging log