r99651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99650‎ | r99651 | r99652 >
Date:21:39, 12 October 2011
Author:wikinaut
Status:ok (Comments)
Tags:
Comment:
convenience function call addExtensionField was lacking the true parameter for the sqlPath. I added that
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
——@@ -186,7 +186,7 @@
187187 * @param $sqlPath string
188188 */
189189 public function addExtensionField( $tableName, $columnName, $sqlPath ) {
190 - $this->extensionUpdates[] = array( 'addField', $tableName, $columnName, $sqlPath );
 190+ $this->extensionUpdates[] = array( 'addField', $tableName, $columnName, $sqlPath, true );
191191 }
192192
193193 /**

Comments

#Comment by Wikinaut (talk | contribs)   21:40, 12 October 2011

otherwise, when running php update.php, a totally wrong path is used, and the sql patch is not found

Status & tagging log