r99537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99536‎ | r99537 | r99538 >
Date:19:11, 11 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
[RL2] Fix version check in Gadgets too, see r99536
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.php
——@@ -17,7 +17,7 @@
1818 die( 1 );
1919 }
2020
21 -if ( version_compare( $wgVersion, '1.19blah', '<' ) ) {
 21+if ( version_compare( $wgVersion, '1.19c', '<' ) ) { // Needs to be 1.18c because version_compare() works in confusing ways
2222 die( "This version of Extension:Gadgets requires MediaWiki 1.19+\n" );
2323 }
2424

Follow-up revisions

RevisionCommit summaryAuthorDate
r100604Fix comment typo in r99537catrope13:29, 24 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99536ACTUALLY fix the version check this timecatrope19:11, 11 October 2011

Comments

#Comment by Krinkle (talk | contribs)   02:34, 12 October 2011

So from 1.19alpha to 1.19bla to 1.18a to 1.18c and now it's 1.19c ? Confusing me, can you double check ?

#Comment by Krinkle (talk | contribs)   02:35, 12 October 2011

Hm.. without the comment it would make sense. I guess it's just the comment copy/paste typo. Nvm :) Less confusing now.

Status & tagging log