r99502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99501‎ | r99502 | r99503 >
Date:17:19, 11 October 2011
Author:demon
Status:deferred (Comments)
Tags:
Comment:
https links to shut up warnings on something I'm testing
Modified paths:
  • /trunk/wikimania/wmreg/skin/form.php (modified) (history)

Diff [purge]

Index: trunk/wikimania/wmreg/skin/form.php
@@ -293,19 +293,19 @@
294294 <td>
295295 <?php get_lang( 'hackingdays' ); ?>:<br>
296296 <input type="checkbox" value="1" name="join_date[]" id="join1" <?php if ( in_array( 1, $register_data['join_date'] ) ) echo 'checked="checked"'; ?>/>
297 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Developer_meetings" onClick="return popup(this, 'join1')"><?php get_lang( 'join1' ); ?></a><br>
 297+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Developer_meetings" onClick="return popup(this, 'join1')"><?php get_lang( 'join1' ); ?></a><br>
298298 <input type="checkbox" value="2" name="join_date[]" id="join2" <?php if ( in_array( 2, $register_data['join_date'] ) ) echo 'checked="checked"'; ?>/>
299 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Developer_meetings" onClick="return popup(this, 'join2')"><?php get_lang( 'join2' ); ?></a><br>
 299+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Developer_meetings" onClick="return popup(this, 'join2')"><?php get_lang( 'join2' ); ?></a><br>
300300 <strong><?php get_lang( 'maindays' ); ?>:<br>
301301 <input type="checkbox" value="3" name="join_date[]" id="join3" <?php if ( in_array( 3, $register_data['join_date'] ) ) echo 'checked="checked"'; ?>/>
302 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Thursday.2C_August_4th" onClick="return popup(this, 'join3')"><?php get_lang( 'join3' ); ?></a><br>
 302+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Thursday.2C_August_4th" onClick="return popup(this, 'join3')"><?php get_lang( 'join3' ); ?></a><br>
303303 <input type="checkbox" value="4" name="join_date[]" id="join4" <?php if ( in_array( 4, $register_data['join_date'] ) ) echo 'checked="checked"'; ?>/>
304 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Friday.2C_August_5th" onClick="return popup(this, 'join4')"><?php get_lang( 'join4' ); ?></a><br>
 304+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Friday.2C_August_5th" onClick="return popup(this, 'join4')"><?php get_lang( 'join4' ); ?></a><br>
305305 <input type="checkbox" value="5" name="join_date[]" id="join5" <?php if ( in_array( 5, $register_data['join_date'] ) ) echo 'checked="checked"'; ?>/>
306 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Saturday.2C_August_6th" onClick="return popup(this, 'join5')"><?php get_lang( 'join5' ); ?></a><br>
 306+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Saturday.2C_August_6th" onClick="return popup(this, 'join5')"><?php get_lang( 'join5' ); ?></a><br>
307307 </strong><?php get_lang( 'tourdays' ); ?>:<br>
308308 <input type="checkbox" value="6" name="join_date[]" id="join6" <?php if ( in_array( 6, $register_data['join_date'] ) ) echo 'checked="checked"'; ?> onclick='flip(["tour0","tour1","tour2","tour3","tour4","tour5"])'/>
309 - <a href="http://wikimania2011.wikimedia.org/wiki/Schedule#Sunday.2C_August_7th" onClick="return popup(this, 'join6')"><?php get_lang( 'join6' ); ?></a><br>
 309+ <a href="https://wikimania2011.wikimedia.org/wiki/Schedule#Sunday.2C_August_7th" onClick="return popup(this, 'join6')"><?php get_lang( 'join6' ); ?></a><br>
310310 </td>
311311 </tr>
312312 <tr>
@@ -316,15 +316,15 @@
317317 <input type="radio" value="0" name="tours" id="tour0" <?php if ( $register_data['tours'] == 0 || empty( $register_data['tour'] ) ) echo 'checked="checked"'; ?> <?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
318318 <?php get_lang( 'tour0' ); ?><br>
319319 <input type="radio" value="1" name="tours" id="tour1" <?php if ( $register_data['tours'] == 1 ) echo 'checked="checked"'; ?><?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
320 - <a href="http://wikimania2011.wikimedia.org/wiki/Tours/Nazareth_and_the_Galilee" onClick="return popup(this, 'tour1')"><?php get_lang( 'tour1' ); ?></a><br>
 320+ <a href="https://wikimania2011.wikimedia.org/wiki/Tours/Nazareth_and_the_Galilee" onClick="return popup(this, 'tour1')"><?php get_lang( 'tour1' ); ?></a><br>
321321 <input type="radio" value="2" name="tours" id="tour2" <?php if ( $register_data['tours'] == 2 ) echo 'checked="checked"'; ?><?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
322 - <a href="http://wikimania2011.wikimedia.org/wiki/Tours/Jerusalem" onClick="return popup(this, 'tour2')"><?php get_lang( 'tour2' ); ?></a><br>
 322+ <a href="https://wikimania2011.wikimedia.org/wiki/Tours/Jerusalem" onClick="return popup(this, 'tour2')"><?php get_lang( 'tour2' ); ?></a><br>
323323 <input type="radio" value="3" name="tours" id="tour3" <?php if ( $register_data['tours'] == 3 ) echo 'checked="checked"'; ?><?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
324 - <a href="http://wikimania2011.wikimedia.org/wiki/Tours/Acre_(Acco)" onClick="return popup(this, 'tour3')"><?php get_lang( 'tour3' ); ?></a><br>
 324+ <a href="https://wikimania2011.wikimedia.org/wiki/Tours/Acre_(Acco)" onClick="return popup(this, 'tour3')"><?php get_lang( 'tour3' ); ?></a><br>
325325 <input type="radio" value="4" name="tours" id="tour4" <?php if ( $register_data['tours'] == 4 ) echo 'checked="checked"'; ?> <?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
326 - <a href="http://wikimania2011.wikimedia.org/wiki/Tours/The_Baha%27i_Gardens" onClick="return popup(this, 'tour4')"><?php get_lang( 'tour4' ); ?></a><br>
 326+ <a href="https://wikimania2011.wikimedia.org/wiki/Tours/The_Baha%27i_Gardens" onClick="return popup(this, 'tour4')"><?php get_lang( 'tour4' ); ?></a><br>
327327 <input type="radio" value="5" name="tours" id="tour5" <?php if ( $register_data['tours'] == 5 ) echo 'checked="checked"'; ?> <?php if ( !in_array( 6, $register_data['join_date'] ) ) echo 'disabled=True'; ?>/>
328 - <a href="http://wikimania2011.wikimedia.org/wiki/Tours/Druze_villages" onClick="return popup(this, 'tour5')"><?php get_lang( 'tour5' ); ?></a><br>
 328+ <a href="https://wikimania2011.wikimedia.org/wiki/Tours/Druze_villages" onClick="return popup(this, 'tour5')"><?php get_lang( 'tour5' ); ?></a><br>
329329 </td>
330330 <tr>
331331 <td><?php create_label( 'showname', true ) ?></td>
@@ -495,18 +495,18 @@
496496 <td><?php create_label( 'accommodation_hotel' ); ?></td>
497497 <td>
498498 <input type="radio" value="1" name="hotels" id="hotel1" <?php if ( $register_data['hotels'] == 1 ) echo 'checked="checked"'; ?> disabled=True/>
499 - <a href="http://wikimania2011.wikimedia.org/wiki/Accommodation/Dorms" onClick="return popup(this, 'hotel1')"><?php create_label( 'hotel1' ); ?></a><br>
 499+ <a href="https://wikimania2011.wikimedia.org/wiki/Accommodation/Dorms" onClick="return popup(this, 'hotel1')"><?php create_label( 'hotel1' ); ?></a><br>
500500 <?php get_lang( 'hotel3stars' ); ?>:<br>
501501 <input type="radio" value="2" name="hotels" id="hotel2" <?php if ( $register_data['hotels'] == 2 ) echo 'checked="checked"'; ?> disabled=True/>
502 - <a href="http://wikimania2011.wikimedia.org/wiki/Accommodation/Three_Stars_Hotels#Dan_Gardens_.28.2A.2A.2A.29" onClick="return popup(this, 'hotel2')"><?php create_label( 'hotel2' ); ?></a><br>
 502+ <a href="https://wikimania2011.wikimedia.org/wiki/Accommodation/Three_Stars_Hotels#Dan_Gardens_.28.2A.2A.2A.29" onClick="return popup(this, 'hotel2')"><?php create_label( 'hotel2' ); ?></a><br>
503503 <?php get_lang( 'hotel4stars' ); ?>:<br>
504504 <input type="radio" value="4" name="hotels" id="hotel4" <?php if ( $register_data['hotels'] == 4 ) echo 'checked="checked"'; ?> disabled=True/>
505 - <a href="http://wikimania2011.wikimedia.org/wiki/Accommodation/Four_Stars_Hotels#Mount_Carmel_.28.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel4')"><?php create_label( 'hotel4' ); ?></a><br>
 505+ <a href="https://wikimania2011.wikimedia.org/wiki/Accommodation/Four_Stars_Hotels#Mount_Carmel_.28.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel4')"><?php create_label( 'hotel4' ); ?></a><br>
506506 <input type="radio" value="5" name="hotels" id="hotel5" <?php if ( $register_data['hotels'] == 5 ) echo 'checked="checked"'; ?> disabled=True/>
507 - <a href="http://wikimania2011.wikimedia.org/wiki/Accommodation/Four_Stars_Hotels#Nof_.28.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel5')"><?php create_label( 'hotel5' ); ?></a><br>
 507+ <a href="https://wikimania2011.wikimedia.org/wiki/Accommodation/Four_Stars_Hotels#Nof_.28.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel5')"><?php create_label( 'hotel5' ); ?></a><br>
508508 <?php get_lang( 'hotel5stars' ); ?>:<br>
509509 <input type="radio" value="6" name="hotels" id="hotel6" <?php if ( $register_data['hotels'] == 6 ) echo 'checked="checked"'; ?>/>
510 - <a href="http://wikimania2011.wikimedia.org/wiki/Accommodation/Five_Stars_Hotels#Dan_Panorama_.28.2A.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel6')"><?php create_label( 'hotel6' ); ?></a><br>
 510+ <a href="https://wikimania2011.wikimedia.org/wiki/Accommodation/Five_Stars_Hotels#Dan_Panorama_.28.2A.2A.2A.2A.2A.29" onClick="return popup(this, 'hotel6')"><?php create_label( 'hotel6' ); ?></a><br>
511511 <?php
512512 ?>
513513 </td>

Comments

#Comment by Hashar (talk | contribs)   15:08, 25 November 2011

Maybe you could use relative URLs?

Status & tagging log