r99483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99482‎ | r99483 | r99484 >
Date:15:25, 11 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.18wmf1: Fix method call, part of r99038
Modified paths:
  • /branches/wmf/1.18wmf1/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/diff/DifferenceEngine.php
@@ -189,11 +189,11 @@
190190 global $wgCanonicalServer, $wgScript, $wgLang;
191191 $wgOut->disable();
192192 header ( "Content-type: application/x-external-editor; charset=UTF-8" );
193 - $url1 = $this->mTitle->getCanonical( array(
 193+ $url1 = $this->mTitle->getCanonicalUrl( array(
194194 'action' => 'raw',
195195 'oldid' => $this->mOldid
196196 ) );
197 - $url2 = $this->mTitle->getCanonical( array(
 197+ $url2 = $this->mTitle->getCanonicalUrl( array(
198198 'action' => 'raw',
199199 'oldid' => $this->mNewid
200200 ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99038Big cleanup to DifferenceEngine:...ialex19:55, 5 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   18:59, 11 October 2011

please consider tagging for 1.18

Status & tagging log