r99480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99479‎ | r99480 | r99481 >
Date:15:07, 11 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 31526) Per r84765 CR, change timestamp() to timestampOrNull().
Modified paths:
  • /branches/wmf/1.18wmf1/includes/api/ApiQueryWatchlist.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/api/ApiQueryWatchlist.php
@@ -135,8 +135,8 @@
136136 $db = $this->getDB();
137137
138138 $this->addWhereRange( 'rc_timestamp', $params['dir'],
139 - $db->timestamp( $params['start'] ),
140 - $db->timestamp( $params['end'] ) );
 139+ $db->timestampOrNull( $params['start'] ),
 140+ $db->timestampOrNull( $params['end'] ) );
141141 $this->addWhereFld( 'wl_namespace', $params['namespace'] );
142142
143143 if ( !$params['allrev'] ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84765(bug 28070) Fix watchlist RSS for databases that store timestamps in a real t...btongminh21:05, 25 March 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   19:00, 11 October 2011

please consider tagging for 1.18 as well

Status & tagging log