r99404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99403‎ | r99404 | r99405 >
Date:14:56, 10 October 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Include a talk link in the default user signature. This seams to be what most people expect, it's the most user friendly, and it's strange we don't include it by default.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4464,7 +4464,7 @@
44654465 'hebrew-calendar-m12-gen' => 'Elul', # only translate this message to other languages if you have to change it
44664466
44674467 # Signatures
4468 -'signature' => '[[{{ns:user}}:$1|$2]]', # do not translate or duplicate this message to other languages
 4468+'signature' => '[[{{ns:user}}:$1|$2]] <sup>([[{{ns:user_talk}}:$1|talk]])</sup>',
44694469 'signature-anon' => '[[{{#special:Contributions}}/$1|$2]]', # do not translate or duplicate this message to other languages
44704470 'timezone-utc' => 'UTC', # only translate this message to other languages if you have to change it
44714471
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -70,6 +70,7 @@
7171 * (bug 31233) New OutputPage::addJsConfigVars() method to make the output page specific
7272 mw.config map extendable.
7373 * (bug 31297) Add support for namespaces in Special:RecentChanges subpage filter syntax.
 74+* The default user signature now contains a talk link in addition to the user link.
7475
7576 === Bug fixes in 1.19 ===
7677 * $wgUploadNavigationUrl should be used for file redlinks if

Follow-up revisions

RevisionCommit summaryAuthorDate
r99422Per r99404: message has translatable content nowraymond20:19, 10 October 2011
r100002Followup r99404, remove <sup> tags.dantman22:56, 16 October 2011

Comments

#Comment by Raymond (talk | contribs)   20:21, 10 October 2011

Please add message documentation for the newly added messages. Thanks.

#Comment by Dantman (talk | contribs)   22:36, 16 October 2011

r99547 seams to have added it.

#Comment by Leinad (talk | contribs)   21:40, 12 October 2011

Why with ""? On the biggest wikis there is just "$2 (talk)".

#Comment by Leinad (talk | contribs)   21:44, 12 October 2011

Forgot to add <nowiki></nowiki>...

Why with "<sup></sup>"? On the biggest wikis there is just "([[{{ns:user_talk}}:$1|talk]])".

#Comment by Dantman (talk | contribs)   21:45, 12 October 2011

It made sense, want me to remove it? ~~~~

#Comment by Leinad (talk | contribs)   21:54, 12 October 2011

Yes, imo <sup></sup> tags should be removed.

Status & tagging log