r99366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99365‎ | r99366 | r99367 >
Date:18:51, 9 October 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
follow up to r99360 & updated urls
Modified paths:
  • /trunk/extensions/Contest/Contest.i18n.php (modified) (history)
  • /trunk/extensions/Contest/Contest.php (modified) (history)
  • /trunk/extensions/Contest/Contest.settings.php (modified) (history)
  • /trunk/extensions/Contest/INSTALL (modified) (history)
  • /trunk/extensions/Contest/README (modified) (history)
  • /trunk/extensions/Contest/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Contest/resources/contest.contestant.pager.css (modified) (history)
  • /trunk/extensions/Contest/resources/contest.contestant.pager.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.contests.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.editcontest.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.signup.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.submission.js (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.welcome.css (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.welcome.js (modified) (history)
  • /trunk/extensions/Contest/resources/jquery.contestChallanges.js (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestant.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.i18n.php
@@ -167,7 +167,8 @@
168168 'contest-contestant-notsubmitted' => 'Not submitted yet',
169169 'contest-contestant-comments' => 'Comments',
170170 'contest-contestant-submit' => 'Save changes',
171 - 'contest-contestant-comment-by' => 'Comment by $1'
 171+ 'contest-contestant-comment-by' => 'Comment by $1',
 172+ 'contest-contestant-rate' => 'Rate this contestant',
172173 );
173174
174175 /** Message documentation (Message documentation)
Index: trunk/extensions/Contest/README
@@ -1,6 +1,6 @@
22 These is the readme file for the Contest extension.
33
4 -Extension page on mediawiki.org: http://www.mediawiki.org/wiki/Extension:Contest
 4+Extension page on mediawiki.org: https://www.mediawiki.org/wiki/Extension:Contest
55 Latest version of the readme file: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Contest/README?view=co
66
77 == About ==
Index: trunk/extensions/Contest/specials/SpecialContestant.php
@@ -106,6 +106,8 @@
107107 $this->showComments( $contestant );
108108
109109 $out->addHTML( '</form>' );
 110+
 111+ $out->addModules( 'contest.special.contestant' );
110112 }
111113
112114 /**
@@ -198,7 +200,11 @@
199201 * @param ContestContestant $contestant
200202 */
201203 protected function showRating( ContestContestant $contestant ) {
 204+ $out = $this->getOutput();
202205
 206+ $out->addHTML( Html::element( 'h2', array(), wfMsg( 'contest-contestant-rate' ) ) );
 207+
 208+
203209 }
204210
205211 /**
@@ -249,12 +255,12 @@
250256 'contest-contestant-comment-by',
251257 Linker::userLink( $comment->getField( 'user_id' ), $user->getName() ) .
252258 Linker::userToolLinks( $comment->getField( 'user_id' ), $user->getName() )
253 - ) . '&#160;&#160;&#160;' .$this->getLang()->timeanddate( $comment->getField( 'time' ), true )
 259+ ) . '&#160;&#160;&#160;' . $this->getLang()->timeanddate( $comment->getField( 'time' ), true )
254260 );
255261
256262 $html .= Html::rawElement(
257263 'div',
258 - array( 'class' => 'contestant-comment-text' ),
 264+ array( 'class' => 'contestant-comment-text mw-content-' . $this->getLang()->getDir() . '' ),
259265 $this->getOutput()->parse( $comment->getField( 'text' ) )
260266 );
261267
Index: trunk/extensions/Contest/Contest.settings.php
@@ -2,7 +2,7 @@
33
44 /**
55 * File defining the settings for the Contest extension.
6 - * More info can be found at http://www.mediawiki.org/wiki/Extension:Contest#Settings
 6+ * More info can be found at https://www.mediawiki.org/wiki/Extension:Contest#Settings
77 *
88 * NOTICE:
99 * Changing one of these settings can be done by assigning to $egContestSettings,
Index: trunk/extensions/Contest/Contest.php
@@ -3,8 +3,8 @@
44 /**
55 * Initialization file for the Contest extension.
66 *
7 - * Documentation: http://www.mediawiki.org/wiki/Extension:Contest
8 - * Support http://www.mediawiki.org/wiki/Extension_talk:Contest
 7+ * Documentation: https://www.mediawiki.org/wiki/Extension:Contest
 8+ * Support https://www.mediawiki.org/wiki/Extension_talk:Contest
99 * Source code: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Contest
1010 *
1111 * @file Contest.php
@@ -209,6 +209,12 @@
210210 ),
211211 );
212212
 213+$wgResourceModules['contest.special.contestant'] = $moduleTemplate + array(
 214+ 'styles' => array(
 215+ 'contest.special.contestant.css',
 216+ ),
 217+);
 218+
213219 unset( $moduleTemplate );
214220
215221 $egContestSettings = array();
Index: trunk/extensions/Contest/INSTALL
@@ -1,6 +1,6 @@
22 These is the install file for the Contest extension.
33
4 -Extension page on mediawiki.org: http://www.mediawiki.org/wiki/Extension:Contest
 4+Extension page on mediawiki.org: https://www.mediawiki.org/wiki/Extension:Contest
55 Latest version of the install file: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Contest/INSTALL?view=co
66
77
Index: trunk/extensions/Contest/RELEASE-NOTES
@@ -1,6 +1,6 @@
22 These are the release notes for the Contest extension.
33
4 -Extension page on mediawiki.org: http://www.mediawiki.org/wiki/Extension:Contest
 4+Extension page on mediawiki.org: https://www.mediawiki.org/wiki/Extension:Contest
55 Latest version of the release notes: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Contest/RELEASE-NOTES?view=co
66
77
Index: trunk/extensions/Contest/resources/contest.special.welcome.css
@@ -1,6 +1,6 @@
22 /**
33 * CSS for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.special.submission.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.special.welcome.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.contestant.pager.css
@@ -1,6 +1,6 @@
22 /**
33 * CSS for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.contestant.pager.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.special.contests.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/jquery.contestChallanges.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.special.editcontest.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
Index: trunk/extensions/Contest/resources/contest.special.signup.js
@@ -1,6 +1,6 @@
22 /**
33 * JavasSript for the Contest MediaWiki extension.
4 - * @see https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Extension:Contest
 4+ * @see https://www.mediawiki.org/wiki/Extension:Contest
55 *
66 * @licence GNU GPL v3 or later
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>

Follow-up revisions

RevisionCommit summaryAuthorDate
r99367Follow up to r99366; added missing filejeroendedauw18:52, 9 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99360initial woek on commenting amd voting ui for judgesjeroendedauw18:05, 9 October 2011

Status & tagging log