r99237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99236‎ | r99237 | r99238 >
Date:19:16, 7 October 2011
Author:jpostlethwaite
Status:resolved (Comments)
Tags:fundraising 
Comment:
Added test credit card.
Modified paths:
  • /branches/fundraising/extensions/DonationInterface/tests/TestConfiguration.php.dist (modified) (history)

Diff [purge]

Index: branches/fundraising/extensions/DonationInterface/tests/TestConfiguration.php.dist
@@ -38,3 +38,10 @@
3939 */
4040 define( 'TESTS_HOSTNAME', 'localhost' );
4141
 42+/**
 43+ * TESTS_CREDIT_CARDS_AMEREICAN_EXPRESS_VALID_CARD
 44+ *
 45+ * A valid American Express Ccard
 46+ */
 47+define( 'TESTS_CREDIT_CARDS_AMEREICAN_EXPRESS_VALID_CARD', '378282246310005' );
 48+

Comments

#Comment by Awjrichards (talk | contribs)   22:42, 7 October 2011

Out of curiosity, where did this cc # come from? Is it valid in the sense that it passes the Luhn algorithm check, a legit card (!) or taken from testing documentation for some provider? If the latter, it is likely gateway-specific. If the former, sweet. If the middle... well... now I know what I'm using to do my Christmas shopping!

#Comment by Jpostlethwaite (talk | contribs)   22:51, 7 October 2011

It is the card hard coded in gateway_common/DonationData.php on Line 113.

#Comment by Awjrichards (talk | contribs)   22:55, 7 October 2011

Ahha - then it is a testing card # provided by PayflowPro. Will this work with GlobalCollect?

Status & tagging log