r99191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99190‎ | r99191 | r99192 >
Date:04:24, 7 October 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
keeping code within 80 char margins for better readability
Modified paths:
  • /trunk/extensions/CentralNotice/centralnotice.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/centralnotice.js
@@ -68,9 +68,13 @@
6969 switch( buttonType ) {
7070 case 'close': // Insert close button
7171 if ( $( '#fundraising' ).is( ':checked' ) ) {
72 - var buttonValue = '<a href="#" onclick="hideBanner(\'fundraising\');return false;"><img border="0" src="' + mw.config.get( 'stylepath' ) + '/common/images/closewindow.png" alt="Close" /></a>';
 72+ var buttonValue = '<a href="#" onclick="hideBanner(\'fundraising\');return false;">'
 73+ + '<img border="0" src="' + mw.config.get( 'stylepath' )
 74+ + '/common/images/closewindow.png" alt="Close" /></a>';
7375 } else {
74 - var buttonValue = '<a href="#" onclick="hideBanner();return false;"><img border="0" src="' + mw.config.get( 'stylepath' ) + '/common/images/closewindow.png" alt="Close" /></a>';
 76+ var buttonValue = '<a href="#" onclick="hideBanner();return false;">'
 77+ + '<img border="0" src="' + mw.config.get( 'stylepath' )
 78+ + '/common/images/closewindow.png" alt="Close" /></a>';
7579 }
7680 break;
7781 }
@@ -84,8 +88,8 @@
8589 var startPos = bannerField.selectionStart;
8690 var endPos = bannerField.selectionEnd;
8791 bannerField.value = bannerField.value.substring(0, startPos)
88 - + buttonValue
89 - + bannerField.value.substring(endPos, bannerField.value.length);
 92+ + buttonValue
 93+ + bannerField.value.substring(endPos, bannerField.value.length);
9094 } else {
9195 bannerField.value += buttonValue;
9296 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r100100MFT r92510, r92676, r96496, r97304, r99160, r99165, r99169, r99176, r99178, r...awjrichards23:56, 17 October 2011

Status & tagging log