r99111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99110‎ | r99111 | r99112 >
Date:15:04, 6 October 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix usage of @

Documentation
Modified paths:
  • /trunk/extensions/Translate/utils/StatsTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/StatsTable.php
@@ -246,8 +246,8 @@
247247 /**
248248 * Check whether translations in given group in given language
249249 * has been disabled.
250 - * @param $groupId string \Message group id
251 - * @param $code string \Language code
 250+ * @param $groupId string Message group id
 251+ * @param $code string Language code
252252 * @return bool
253253 */
254254 public function isBlacklisted( $groupId, $code ) {
@@ -262,7 +262,9 @@
263263 );
264264
265265 foreach ( $checks as $check ) {
266 - $blacklisted = @$wgTranslateBlacklist[$check][$code];
 266+ if ( isset( $wgTranslateBlacklist[$check] ) && isset( $wgTranslateBlacklist[$check][$code] ) ) {
 267+ $blacklisted = $wgTranslateBlacklist[$check][$code];
 268+ }
267269
268270 if ( $blacklisted !== null ) {
269271 break;

Comments

#Comment by Nikerabbit (talk | contribs)   17:38, 6 October 2011
-	 * @param $groupId string \Message group id
-	 * @param $code string \Language code
+	 * @param $groupId string Message group id
+	 * @param $code string Language code

I think I meant %Message and %Language here.

Status & tagging log