r99080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99079‎ | r99080 | r99081 >
Date:09:44, 6 October 2011
Author:philip
Status:ok (Comments)
Tags:
Comment:
Fix Bug:31396. The bug was cause by r86861, which used CSS sprites to change the appearance of the arrow when the element is focused. This revision separate the focus arrow from the sprites image because it hardly possible to adjust the position of image **when the width are unfixed**.
Modified paths:
  • /trunk/phase3/skins/vector/images/arrow-down-focus-icon.png (added) (history)
  • /trunk/phase3/skins/vector/images/arrow-down-icon.png (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/images/arrow-down-focus-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/skins/vector/images/arrow-down-focus-icon.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/phase3/skins/vector/images/arrow-down-icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/phase3/skins/vector/screen.css
——@@ -211,12 +211,14 @@
212212 float: left;
213213 /* @embed */
214214 background-image: url(images/arrow-down-icon.png);
215 - background-position: 0px 60%;
 215+ background-position: 100% 60%;
216216 background-repeat: no-repeat;
217217 cursor: pointer;
218218 }
219219 div.vectorMenuFocus {
220 - background-position: -22px 60%;
 220+ /* @embed */
 221+ background-image: url(images/arrow-down-focus-icon.png);
 222+ background-position: 100% 60%;
221223 }
222224 /* @noflip */
223225 body.rtl div.vectorMenu {

Sign-offs

UserFlagDate
He7d3rtested23:22, 6 October 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r99081Follow r86861, replace spaces with tabs. It's my vim's fault!philip09:49, 6 October 2011
r99087Fix MIME type for image added in r99080catrope12:00, 6 October 2011
r99977MFT r99080demon22:10, 16 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86861(bug 24298) Make dropdown menus in Vector more accessible by expanding and co...catrope14:08, 25 April 2011

Comments

#Comment by He7d3r (talk | contribs)   23:20, 6 October 2011

I confirm that this fixes bug 31396 (which currently still happens on pages such as s:pt:Elementos de Arithmetica/Capítulo 1).

#Comment by Krinkle (talk | contribs)   00:17, 8 October 2011

For an icon like this it's not a big deal, but in general when splitting up a file in two or more smaller files (goes for images too) it is recommended to use 'svn copy' to duplicate the file and then modify the two files (instead of modifying one file (removing stuff), and adding a new file with that content) - to preserve history.

Status & tagging log