r99025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99024‎ | r99025 | r99026 >
Date:18:45, 5 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
Adding fixme comment above an old piece of code that I'd rather not change right now
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2022,6 +2022,8 @@
20232023 public function getSkinFromCssJsSubpage() {
20242024 $subpage = explode( '/', $this->mTextform );
20252025 $subpage = $subpage[ count( $subpage ) - 1 ];
 2026+ // FIXME: Should only match endings
 2027+ // Consider 'Foo/.js.monobook' or 'Foo/mon.js.obook.css'
20262028 return( str_replace( array( '.css', '.js' ), array( '', '' ), $subpage ) );
20272029 }
20282030

Follow-up revisions

RevisionCommit summaryAuthorDate
r99148Solve the FIXME set in r99025....platonides21:43, 6 October 2011

Status & tagging log