r98976 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98975‎ | r98976 | r98977 >
Date:02:38, 5 October 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
MFT r98975
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthUser.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CentralAuth/CentralAuthUser.php
@@ -1109,7 +1109,13 @@
11101110 /* $allowUsertalk */ false,
11111111 /* $byName */ $by
11121112 );
1113 -
 1113+ // Live hack for $by not being used anymore, --aaron
 1114+ $foreignUser = User::newFromName( $by, false );
 1115+ $foreignUser->setId( 0 );
 1116+ $foreignUser->setItemLoaded( 'id' ); // hack around Block::getDatabaseArray()
 1117+ $block->setBlocker( $foreignUser );
 1118+ // end hack
 1119+
11141120 # On normal block, BlockIp hook would be run here, but doing
11151121 # that from CentralAuth doesn't seem a good idea...
11161122
Index: branches/wmf/1.18wmf1/includes/specials/SpecialBlock.php
@@ -499,7 +499,7 @@
500500 list( $ip, $range ) = explode( '/', $target, 2 );
501501
502502 if( ( IP::isIPv4( $ip ) && $wgBlockCIDRLimit['IPv4'] == 32 )
503 - || ( IP::isIPv6( $ip ) && $wgBlockCIDRLimit['IPV6'] == 128 ) )
 503+ || ( IP::isIPv6( $ip ) && $wgBlockCIDRLimit['IPv6'] == 128 ) )
504504 {
505505 # Range block effectively disabled
506506 return wfMessage( 'range_block_disabled' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r98977Reverted stuff committed in r98976 by mistakeaaron02:44, 5 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98975Fixed:...aaron02:36, 5 October 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   02:38, 5 October 2011

Didn't mean to merge CA stuff right now.

Status & tagging log