r98942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98941‎ | r98942 | r98943 >
Date:22:32, 4 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] Stop propagation of clicks on other anchor tags inside the gadget row.
* Fixes bug introduced in r98735
Modified paths:
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.js (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.js
@@ -185,8 +185,13 @@
186186 t = new mw.Title( 'Gadgets/' + id, -1 );
187187 }
188188 window.location.href = t.getUrl();
189 - } );
190189
 190+ } ).find( 'a' ).click( function( e ) {
 191+ // Avoid other links from becoming unclickable,
 192+ // Don't let clicks on those bubble up
 193+ e.stopPropagation();
 194+ });
 195+
191196 if ( ga.conf.userIsAllowed['gadgets-definition-create'] ) {
192197 var createTab = mw.util.addPortletLink(
193198 // Not all skins use the new separated tabs yet,

Follow-up revisions

RevisionCommit summaryAuthorDate
r98995[RL2] Fix grammar in comment added in r98942catrope12:34, 5 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98735[RL2] Entire gadget row is now clickablekrinkle02:41, 3 October 2011

Status & tagging log