r98889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98888‎ | r98889 | r98890 >
Date:19:59, 4 October 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Followup r98578 convert nulls to string
Modified paths:
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateEditAddons.php
——@@ -258,7 +258,7 @@
259259
260260 $th = new TranslationHelpers( $object->mTitle );
261261 if ( $object->firsttime && !$wgRequest->getCheck( 'oldid' ) && !$wgRequest->getCheck( 'undo' ) ) {
262 - $object->textbox1 = $th->getTranslation();
 262+ $object->textbox1 = (string) $th->getTranslation();
263263 } else {
264264 $th->setTranslation( $object->textbox1 );
265265 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98578* (bug 12130) Initial newlines are now preserved correctly during editing...brion22:50, 30 September 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   21:32, 4 October 2011

Is this a correction of the Translate bug referred to in [1] ?

#Comment by Nikerabbit (talk | contribs)   21:42, 4 October 2011

Yes.

Status & tagging log