r98748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98747‎ | r98748 | r98749 >
Date:10:55, 3 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r98745: also use protocol-relative URLs for logout links
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthHooks.php
@@ -334,7 +334,8 @@
335335 $wgMemc->set( CentralAuthUser::memcKey( 'login-token', $loginToken ), $data, 600 );
336336
337337 $wiki = WikiMap::getWiki( $wiki );
338 - $url = $wiki->getUrl( 'Special:AutoLogin' );
 338+ // Use WikiReference::getFullUrl(), returns a protocol-relative URL if needed
 339+ $url = $wiki->getFullUrl( 'Special:AutoLogin' );
339340
340341 if ( strpos( $url, '?' ) > 0 ) {
341342 $url .= "&logout=1&token=$loginToken";

Follow-up revisions

RevisionCommit summaryAuthorDate
r987491.17wmf1: MFT r98748catrope10:56, 3 October 2011
r987501.18wmf1: MFT r98748catrope10:57, 3 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98745(bug 31320) CentralAuth uses http URLs for autologin images when logging in o...catrope10:27, 3 October 2011

Status & tagging log