r98744 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r98743
|
r98744
|
r98745
>
Date:
10:24, 3 October 2011
Author:
catrope
Status:
ok
Tags:
Comment:
ExtensionDistributor: Don't display a protocol-relative URL in plain text (or use it in a Location: header, for that matter), but expand it with the current protocol. Bug reported by Paxed on IRC
Modified paths:
/trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
—
—
@@ -249,7 +249,7 @@
250
250
}
251
251
}
252
252
253
- $url = "$wgExtDistTarUrl/$tarName";
253
+ $url = wfExpandUrl( "$wgExtDistTarUrl/$tarName", PROTO_CURRENT );
254
254
255
255
// Show a message
256
256
$wgOut->addWikiMsg( 'extdist-created', $extension, "r$rev",
Sign-offs
User
Flag
Date
Nikerabbit
inspected
16:31, 3 October 2011
Follow-up revisions
Revision
Commit summary
Author
Date
r98746
1.18wmf1: MFT
r98744
,
r98745
catrope
10:42, 3 October 2011
r98747
1.17wmf1: MFT
r98744
,
r98745
catrope
10:42, 3 October 2011
Status & tagging log
21:53, 4 October 2011
😂
(
talk
|
contribs
)
changed the
status
of r98744
[
removed:
new
added:
ok]