r98640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98639‎ | r98640 | r98641 >
Date:23:03, 1 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r98634 make method static, remove comment

Update documentation
Modified paths:
  • /trunk/extensions/ConfirmAccount/dataclasses/ConfirmAccount.class.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/presentation/specialpages/actions/RequestAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/dataclasses/ConfirmAccount.class.php
@@ -124,10 +124,10 @@
125125 /**
126126 * Get a request name from an email confirmation token
127127 *
128 - * @param sring $code
 128+ * @param $code string
129129 * @return string|false
130130 */
131 - public function requestNameFromEmailToken( $code ) {
 131+ public static function requestNameFromEmailToken( $code ) {
132132 $dbr = wfGetDB( DB_SLAVE );
133133 return $dbr->selectField( 'account_requests',
134134 'acr_name',
Index: trunk/extensions/ConfirmAccount/presentation/specialpages/actions/RequestAccount_body.php
@@ -325,7 +325,7 @@
326326 $reqUser = $this->getUser();
327327 $out = $this->getOutput();
328328 # Confirm if this token is in the pending requests
329 - $name = ConfirmAccount::requestNameFromEmailToken( $code ); // FIXME: This method isn't static
 329+ $name = ConfirmAccount::requestNameFromEmailToken( $code );
330330 if ( $name !== false ) {
331331 # Send confirmation email to prospective user
332332 ConfirmAccount::confirmEmail( $name );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98634Add some documentation/explicit variables...reedy22:31, 1 October 2011

Status & tagging log