r98639 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98638‎ | r98639 | r98640 >
Date:23:01, 1 October 2011
Author:reedy
Status:ok
Tags:
Comment:
More comment updates and such
Modified paths:
  • /trunk/extensions/ConfirmAccount/business/AccountRequestSubmission.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/presentation/ConfirmAccountUI.hooks.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/presentation/specialpages/actions/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/business/AccountRequestSubmission.php
@@ -44,6 +44,9 @@
4545 return $this->attachmentDidNotForget;
4646 }
4747
 48+ /**
 49+ * @return string
 50+ */
4851 public function getAttachtmentPrevName() {
4952 return $this->attachmentPrevName;
5053 }
Index: trunk/extensions/ConfirmAccount/presentation/ConfirmAccountUI.hooks.php
@@ -6,6 +6,10 @@
77 /**
88 * Register ConfirmAccount special pages as needed.
99 * Also sets $wgSpecialPages just to be consistent.
 10+ *
 11+ * @param $list array
 12+ *
 13+ * @return true
1014 */
1115 public static function defineSpecialPages( array &$list ) {
1216 global $wgSpecialPages, $wgSpecialPageGroups, $wgConfirmAccountSaveInfo;
Index: trunk/extensions/ConfirmAccount/presentation/specialpages/actions/ConfirmAccount_body.php
@@ -223,7 +223,10 @@
224224 $out->addHTML( '</ul>' );
225225 }
226226
227 - protected function showAccountConfirmForm( $msg='' ) {
 227+ /**
 228+ * @param $msg string
 229+ */
 230+ protected function showAccountConfirmForm( $msg = '' ) {
228231 global $wgAccountRequestTypes;
229232 $reqUser = $this->getUser();
230233 $out = $this->getOutput();
@@ -435,6 +438,9 @@
436439 StreamFile::stream( $path );
437440 }
438441
 442+ /**
 443+ * @return bool
 444+ */
439445 protected function doAccountConfirmSubmit() {
440446 $reqUser = $this->getUser();
441447 $out = $this->getOutput();
@@ -779,8 +785,10 @@
780786 return true;
781787 }
782788
783 - /*
 789+ /**
784790 * Get requested account request row and load some fields
 791+ *
 792+ * @param $forUpdate bool
785793 */
786794 function getAccountRequest( $forUpdate = false ) {
787795 if( !$this->acrID ) return false;
@@ -846,6 +854,11 @@
847855 return $linkList;
848856 }
849857
 858+ /**
 859+ * @param $titleObj Title
 860+ * @param $name string
 861+ * @param $errors array
 862+ */
850863 protected function showSuccess( $titleObj, $name = null, $errors = array() ) {
851864 $out = $this->getOutput();
852865
@@ -903,6 +916,10 @@
904917 }
905918 }
906919
 920+ /**
 921+ * @param $row
 922+ * @return string
 923+ */
907924 public function formatRow( $row ) {
908925 global $wgUseRealNamesOnly, $wgAllowRealName, $wgMemc;
909926
@@ -1000,14 +1017,24 @@
10011018 $this->mLimit = $urlLimit ? $urlLimit : 20;
10021019 }
10031020
 1021+ /**
 1022+ * @return Title
 1023+ */
10041024 function getTitle() {
10051025 return SpecialPage::getTitleFor( 'ConfirmAccounts', $this->mForm->specialPageParameter );
10061026 }
10071027
 1028+ /**
 1029+ * @param $row
 1030+ * @return string
 1031+ */
10081032 function formatRow( $row ) {
10091033 return $this->mForm->formatRow( $row );
10101034 }
10111035
 1036+ /**
 1037+ * @return string
 1038+ */
10121039 function getStartBody() {
10131040 if ( $this->getNumRows() ) {
10141041 return '<ul>';
@@ -1016,6 +1043,9 @@
10171044 }
10181045 }
10191046
 1047+ /**
 1048+ * @return string
 1049+ */
10201050 function getEndBody() {
10211051 if ( $this->getNumRows() ) {
10221052 return '</ul>';
@@ -1024,6 +1054,9 @@
10251055 }
10261056 }
10271057
 1058+ /**
 1059+ * @return array
 1060+ */
10281061 function getQueryInfo() {
10291062 $conds = $this->mConds;
10301063 $tables = array( 'account_requests' );
@@ -1046,6 +1079,9 @@
10471080 );
10481081 }
10491082
 1083+ /**
 1084+ * @return string
 1085+ */
10501086 function getIndexField() {
10511087 return 'acr_registration';
10521088 }

Status & tagging log