r98540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98539‎ | r98540 | r98541 >
Date:17:35, 30 September 2011
Author:dasch
Status:resolved (Comments)
Tags:
Comment:
added title to link, like all other tabs have (1.2.2)
Modified paths:
  • /trunk/extensions/CreditTab/CreditTab.i18n.php (modified) (history)
  • /trunk/extensions/CreditTab/CreditTab.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CreditTab/CreditTab.i18n.php
@@ -16,18 +16,21 @@
1717 $messages['en'] = array(
1818 'credits-desc' => 'Adds a link to credits',
1919 'credits-tab' => 'Credits',
 20+ 'credits-tab-title' => 'Credits for this page',
2021 );
2122
2223 /** Message documentation (Message documentation) */
2324 $messages['qqq'] = array(
2425 'credits-desc' => 'Description for Special:Version',
2526 'credits-tab' => 'Label of the tab that is shown by this extension',
 27+ 'credits-tab-title' => 'Title of the link that is shown when hovering (Tool-Tip)'
2628 );
2729
2830 /** German (Deutsch) */
2931 $messages['de'] = array(
3032 'credits-desc' => 'Fügt Link zu Autoren hinzu',
3133 'credits-tab' => 'Autoren',
 34+ 'credits-tab-title' => 'Autoren dieser Seite',
3235 );
3336
3437 /** Galician (Galego)
Index: trunk/extensions/CreditTab/CreditTab.php
@@ -15,7 +15,7 @@
1616 'path' => __FILE__,
1717 'name' => 'CreditTab',
1818 'author' => '[http://www.dasch-tour.de DaSch]',
19 - 'version' => '1.2.1',
 19+ 'version' => '1.2.2',
2020 'descriptionmsg' => 'credits-desc',
2121 'url' => 'http://www.mediawiki.org/wiki/Extension:CreditTab',
2222 );
@@ -78,6 +78,7 @@
7979 $credit_tab = array(
8080 'class' => $class_name,
8181 'text' => wfMsg('credits-tab'),
 82+ 'title' => wfMsg('credits-tab-title'),
8283 'href' => $title->getLocalURL( 'action=credits' ),
8384 );
8485 // find the location of the 'edit' tab, and add

Follow-up revisions

RevisionCommit summaryAuthorDate
r106449Fixups for r98540, indentation/formatting, clarify qqq message, move count() ...demon17:43, 16 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:01, 1 October 2011
the link that is shown when hovering

What link? Ambiguous also in sense what is shown when hovering what.

Also introduces spaces for indentation.

Rest is fine.

#Comment by DaSch (talk | contribs)   12:34, 1 October 2011

The tab that is added is a link and the title property adds something like a tooltip when you point with the mouse on it but don't click

#Comment by P858snake (talk | contribs)   06:04, 10 December 2011

Why is this Fixme? The ambiguous i18n message or the Space/Indentation issue?

Status & tagging log