r98445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98444‎ | r98445 | r98446 >
Date:20:38, 29 September 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
fix for r98442 to not use parse_url directly
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
——@@ -84,7 +84,7 @@
8585 }
8686
8787 class ExtMobileFrontend {
88 - const VERSION = '0.5.72';
 88+ const VERSION = '0.5.73';
8989
9090 /**
9191 * @var DOMDocument
——@@ -240,7 +240,7 @@
241241 self::$disableImagesURL = $wgRequest->escapeAppendQuery( 'disableImages=1' );
242242 self::$enableImagesURL = $wgRequest->escapeAppendQuery( 'enableImages=1' );
243243 self::$disableMobileSiteURL = $wgRequest->escapeAppendQuery( 'mobileaction=disable_mobile_site' );
244 - $parsedUrl = parse_url( $wgRequest->getFullRequestURL() );
 244+ $parsedUrl = wfParseUrl( $wgRequest->getFullRequestURL() );
245245 $parsedUrl['host'] = str_replace( $wgMobileDomain, '.', $parsedUrl['host'] );
246246 $parsedUrl['query'] = $this->removeQueryStringParameter( $parsedUrl['query'], 'useformat' );
247247 $fragmentDelimiter = ( !empty( $parsedUrl['fragment'] ) ) ? '#' : '';

Follow-up revisions

RevisionCommit summaryAuthorDate
r98448mft r98427 r98442 r98445preilly21:02, 29 September 2011
r98449mft r98427 r98442 r98445preilly21:02, 29 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98442fix for r98427 to avoid false positives on mobile domain removalpreilly20:28, 29 September 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   08:33, 30 September 2011

Should this (and the other mobile frontend fixes that have been applied to 1.18wmf) be made available to 1.18 as well? We (and probably most mediawiki installations) urgently need the mobile frontend as well.

#Comment by Preilly (talk | contribs)   16:57, 30 September 2011

Yes, they should.

Status & tagging log