r98403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98402‎ | r98403 | r98404 >
Date:07:41, 29 September 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Removed use of $mediaWiki
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -50,6 +50,7 @@
5151 if ( $this->article == null ) {
5252 throw new MWException( 'FlaggedPageView has no context article!' );
5353 }
 54+ // @TODO: store whole request context
5455 $this->out = RequestContext::getMain()->getOutput();
5556 }
5657 }
@@ -1315,9 +1316,9 @@
13161317 * @return bool
13171318 */
13181319 protected function pageWriteOpRequested() {
1319 - global $wgRequest, $mediaWiki;
 1320+ global $wgRequest;
13201321 # Hack for bug 16734 (some actions update and view all at once)
1321 - $action = $mediaWiki->getAction();
 1322+ $action = $wgRequest->getVal( 'action' );
13221323 if ( $action === 'rollback' ) {
13231324 return true;
13241325 } elseif ( $action === 'delete' && $wgRequest->wasPosted() ) {

Comments

#Comment by 😂 (talk | contribs)   13:44, 29 September 2011

You're still using it in two other places :\

#Comment by Aaron Schulz (talk | contribs)   15:40, 29 September 2011

Yep, those ones were tricky to remove. Killing this one at least made rebuildFileCache not die.

Status & tagging log