r98400 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98399‎ | r98400 | r98401 >
Date:05:05, 29 September 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Fix PHP Notice: Undefined index: revision in /www/w/extensions/Translate/tag/PageTranslationHooks.php on line 534
Clearly I wasn't thinking straight when I wrote this code, nor tested the non-default case
Modified paths:
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -523,7 +523,7 @@
524524 $opts = array( 'parseinline', 'language' => $language );
525525
526526 // New logging system already unserializes it for us
527 - if ( is_array( $params ) ) {
 527+ if ( isset( $params['user'] ) ) {
528528 $_ = $params;
529529 } else {
530530 $_ = unserialize( $params[0] );

Status & tagging log