r98399 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98398‎ | r98399 | r98400 >
Date:02:56, 29 September 2011
Author:nad
Status:deferred
Tags:
Comment:
use hash regex delimiter when searching for title
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -186,7 +186,7 @@
187187 # Loop through all records of this type adding only those that match the regex fields
188188 $records = array();
189189 foreach( self::getRecordsByType( $type ) as $t ) {
190 - if( empty( $wpTitle ) || preg_match( "|$wpTitle|i", $t->getPrefixedText() ) ) {
 190+ if( empty( $wpTitle ) || preg_match( "#$wpTitle#i", $t->getPrefixedText() ) ) {
191191 $a = new Article( $t );
192192 $text = $a->getContent();
193193 $match = true;
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -10,7 +10,7 @@
1111 * @author Siebrand Mazeland
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
14 -define( 'RECORDADMIN_VERSION', '1.3.4, 2011-08-18' );
 14+define( 'RECORDADMIN_VERSION', '1.3.5, 2011-09-29' );
1515
1616 $wgRecordAdminExtPath = preg_replace( "|^.*(/extensions/.*$)|", "$wgScriptPath$1", dirname( __FILE__ ) );
1717

Status & tagging log