r98366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98365‎ | r98366 | r98367 >
Date:20:33, 28 September 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
inexisting -> inexistent (typo)
* tests/qunit
* resources/mediawiki
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.Title.js (modified) (history)
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js (modified) (history)
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
——@@ -181,7 +181,7 @@
182182 title = new mw.Title( 'Project:Sandbox rules' );
183183 assertTrue( title.exists(), 'Return true for page titles marked as existing' );
184184 title = new mw.Title( 'Foobar' );
185 - assertFalse( title.exists(), 'Return false for page titles marked as inexisting' );
 185+ assertFalse( title.exists(), 'Return false for page titles marked as inexistent' );
186186
187187 });
188188
Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
——@@ -111,7 +111,7 @@
112112 strictEqual( hello.exists(), true, 'Message.exists returns true for existing messages' );
113113
114114 var goodbye = mw.message( 'goodbye' );
115 - strictEqual( goodbye.exists(), false, 'Message.exists returns false for inexisting messages' );
 115+ strictEqual( goodbye.exists(), false, 'Message.exists returns false for inexistent messages' );
116116
117117 equal( goodbye.plain(), '<goodbye>', 'Message.toString returns plain <key> if format is "plain" and key does not exist' );
118118 // bug 30684
——@@ -124,7 +124,7 @@
125125 ok( mw.messages.set( 'hello', 'Hello <b>awesome</b> world' ), 'mw.messages.set: Register' );
126126
127127 equal( mw.msg( 'hello' ), 'Hello <b>awesome</b> world', 'Gets message with default options (existing message)' );
128 - equal( mw.msg( 'goodbye' ), '<goodbye>', 'Gets message with default options (inexisting message)' );
 128+ equal( mw.msg( 'goodbye' ), '<goodbye>', 'Gets message with default options (inexistent message)' );
129129 });
130130
131131 test( 'mw.loader', function() {
Index: trunk/phase3/resources/mediawiki/mediawiki.Title.js
——@@ -198,7 +198,7 @@
199199 pages: {},
200200 /**
201201 * @example Declare existing titles: Title.exist.set(['User:John_Doe', ...]);
202 - * @example Declare titles inexisting: Title.exist.set(['File:Foo_bar.jpg', ...], false);
 202+ * @example Declare titles inexistent: Title.exist.set(['File:Foo_bar.jpg', ...], false);
203203 * @param titles {String|Array} Title(s) in strict prefixedDb title form.
204204 * @param state {Boolean} (optional) State of the given titles. Defaults to true.
205205 * @return {Boolean}

Follow-up revisions

RevisionCommit summaryAuthorDate
r99029inexistent -> nonexistent...krinkle18:55, 5 October 2011

Comments

#Comment by Tim Starling (talk | contribs)   23:14, 28 September 2011

I think you mean nonexistent.

#Comment by Krinkle (talk | contribs)   01:00, 29 September 2011

Ah, I have no clue. My spell checker suggested this, I've also remember Roan suggesting this spelling when I originally wrote this at the Berlin hackathon this year.

Google brings this up: http://www.answerbag.com/q_view/681294#ixzz1ZIaPdKVn' at which someone says both words exist, but depending on context either both are correct or only one of them ("Nonexistent is a noun whereas inexistent is an adjective"). Although my vocabulary is bad when it comes to English grammar, I think I need to use the adjective here ?

#Comment by Tim Starling (talk | contribs)   01:57, 29 September 2011

According to Wordnet, nonexistent is an adjective and inexistent is not a word. That agrees with my own experience.

Some other dictionaries have "inexistent" in them, as a synonym for nonexistent, but "nonexistent" is much more common.

#Comment by Tim Starling (talk | contribs)   02:05, 29 September 2011

http://corpus.byu.edu/coca/

  • nonexistent: 1641
  • inexistent: 5

Status & tagging log