r98358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98357‎ | r98358 | r98359 >
Date:19:41, 28 September 2011
Author:dasch
Status:deferred
Tags:
Comment:
small change to use standard warningbox to have a consistant UI
like described in #30744
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)
  • /trunk/extensions/SemanticForms/skins/SemanticForms.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -1518,7 +1518,7 @@
15191519 // Add a warning in, if we're editing an existing page and that
15201520 // page appears to not have been created with this form.
15211521 if ( $this->mPageTitle->exists() && ( $existing_page_content != '' ) && ! $source_page_matches_this_form ) {
1522 - $form_text = "\t" . '<div class="warningMessage">' . wfMsg( 'sf_formedit_formwarning', $this->mPageTitle->getFullURL() ) . "</div>\n" . $form_text;
 1522+ $form_text = "\t" . '<div class="warningbox">' . wfMsg( 'sf_formedit_formwarning', $this->mPageTitle->getFullURL() ) . "</div>\n" . $form_text;
15231523 }
15241524
15251525 // add form bottom, if no custom "standard inputs" have been defined
Index: trunk/extensions/SemanticForms/skins/SemanticForms.css
@@ -80,13 +80,12 @@
8181 width: auto;
8282 background: #eeeeee;
8383 }
84 -div.warningMessage {
 84+#sfForm div.warningbox {
8585 border: 2px solid red;
8686 padding: 5px 10px 5px 10px;
8787 margin: 25px;
8888 width: auto;
89 - font-weight: bold;
90 - color: black;
 89+ float:none;
9190 }
9291 span.errorMessage {
9392 color: red;

Follow-up revisions

RevisionCommit summaryAuthorDate
r99170Follow-up to r98358 - improved and standardized display of warning and error ...yaron23:36, 6 October 2011