r98341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98340‎ | r98341 | r98342 >
Date:18:17, 28 September 2011
Author:midom
Status:ok (Comments)
Tags:
Comment:
disable originalTitle profiling, blows up with random crap (e.g. Parser::braceSubstitution-title-#expr: (((abs(52.29601636) - trunc(abs(52.29601636))) * 60 - trunc( (abs(52.29601636) - trunc(abs(52.29601636))) * 60 )) * 60) round 0
Modified paths:
  • /branches/wmf/1.18wmf1/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/parser/Parser.php
——@@ -2957,7 +2957,7 @@
29582958 # @todo FIXME: If piece['parts'] is null then the call to getLength() below won't work b/c this $args isn't an object
29592959 $args = ( null == $piece['parts'] ) ? array() : $piece['parts'];
29602960 wfProfileOut( __METHOD__.'-setup' );
2961 - wfProfileIn( __METHOD__."-title-$originalTitle" );
 2961+ // wfProfileIn( __METHOD__."-title-$originalTitle" );
29622962
29632963 # SUBST
29642964 wfProfileIn( __METHOD__.'-modifiers' );
——@@ -3176,7 +3176,7 @@
31773177 # Recover the source wikitext and return it
31783178 if ( !$found ) {
31793179 $text = $frame->virtualBracketedImplode( '{{', '|', '}}', $titleWithSpaces, $args );
3180 - wfProfileOut( __METHOD__."-title-$originalTitle" );
 3180+ // wfProfileOut( __METHOD__."-title-$originalTitle" );
31813181 wfProfileOut( __METHOD__ );
31823182 return array( 'object' => $text );
31833183 }
——@@ -3245,7 +3245,7 @@
32463246 $ret = array( 'text' => $text );
32473247 }
32483248
3249 - wfProfileOut( __METHOD__."-title-$originalTitle" );
 3249+ // wfProfileOut( __METHOD__."-title-$originalTitle" );
32503250 wfProfileOut( __METHOD__ );
32513251 return $ret;
32523252 }

Comments

#Comment by Aaron Schulz (talk | contribs)   18:21, 28 September 2011

I thought this was a little noisy on my testwiki.

Status & tagging log