r98330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98329‎ | r98330 | r98331 >
Date:16:37, 28 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix whitespace
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -1612,7 +1612,7 @@
16131613 *
16141614 * @param $table String Table name. This will be passed through
16151615 * DatabaseBase::tableName().
1616 - * @param $a Array of rows to insert
 1616+ * @param $a Array of rows to insert
16171617 * @param $fname String Calling function name (use __METHOD__) for logs/profiling
16181618 * @param $options Array of options
16191619 *
Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -51,7 +51,7 @@
5252 $fld_groups = isset( $prop['groups'] );
5353 $fld_rights = isset( $prop['rights'] );
5454 $fld_registration = isset( $prop['registration'] );
55 - $fld_implicitgroups = isset( $prop['implicitgroups'] );
 55+ $fld_implicitgroups = isset( $prop['implicitgroups'] );
5656 } else {
5757 $fld_blockinfo = $fld_editcount = $fld_groups = $fld_registration = $fld_rights = $fld_implicitgroups = false;
5858 }
@@ -257,7 +257,7 @@
258258 }
259259 if ( !is_null( $row->ug_group2 ) ) {
260260 $lastUserData['rights'] = array_unique( array_merge( $lastUserData['rights'],
261 - User::getGroupPermissions( array( $row->ug_group2 ) ) ) );
 261+ User::getGroupPermissions( array( $row->ug_group2 ) ) ) );
262262 }
263263 $result->setIndexedTagName( $lastUserData['rights'], 'r' );
264264 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r98356MFT r98329, r98332 (and whitespace for ApiQueryAllUsers from r98330)reedy19:34, 28 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98329Bug 31199 - Fix notification of implicit groups so it doesn't massively chang...reedy16:36, 28 September 2011

Status & tagging log