r98298 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98297‎ | r98298 | r98299 >
Date:01:28, 28 September 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 31206) "Altering blocks doesn't appear to be working". Don't compare string to User objects :)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -643,7 +643,7 @@
644644 if( !$status ) {
645645 # Show form unless the user is already aware of this...
646646 if( !$data['Confirm'] || ( array_key_exists( 'PreviousTarget', $data )
647 - && $data['PreviousTarget'] !== $block->getTarget() ) )
 647+ && $data['PreviousTarget'] !== $target ) )
648648 {
649649 return array( array( 'ipb_already_blocked', $block->getTarget() ) );
650650 # Otherwise, try to update the block...

Follow-up revisions

RevisionCommit summaryAuthorDate
r98655MFT r98298aaron04:48, 2 October 2011

Comments

#Comment by P858snake (talk | contribs)   12:44, 28 September 2011

Can someone tag this for 1.18 please.

Status & tagging log