r98284 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98283‎ | r98284 | r98285 >
Date:23:15, 27 September 2011
Author:aaron
Status:ok (Comments)
Tags:todo 
Comment:
Backup wikiversions.dat for easier rollback
Modified paths:
  • /trunk/tools/mwmultiversion/multiversion/switchAllMediaWikis (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/switchAllMediaWikis
@@ -59,7 +59,14 @@
6060 }
6161 }
6262
63 - # Create wikiversions.dat...
 63+ # Backup old wikiversions.dat...
 64+ $backupPath = "$common/multiversion/backup/wikiversions-" . time() . ".dat";
 65+ if ( !copy( "$common/wikiversions.dat", $backupPath ) ) {
 66+ die( "Unable to write backup file `$backupPath`.\n" );
 67+ }
 68+ echo "Wrote backup file `$backupPath`.\n";
 69+
 70+ # Update wikiversions.dat...
6471 if ( !file_put_contents( $path, $datList ) ) {
6572 die( "Unable to write to wikiversions.dat.\n" );
6673 }

Comments

#Comment by Catrope (talk | contribs)   20:39, 4 October 2011
+	$backupPath = "$common/multiversion/backup/wikiversions-" . time() . ".dat";

It would be nicer to use a human-readable timestamp format.

Status & tagging log