r98246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98245‎ | r98246 | r98247 >
Date:20:09, 27 September 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Apply r98242 to rebuildInterwiki.php too. Rawr code duplication
Modified paths:
  • /trunk/extensions/WikimediaMaintenance/rebuildInterwiki.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaMaintenance/rebuildInterwiki.php
@@ -142,7 +142,7 @@
143143 if ( preg_match( '/^\|\s*(.*?)\s*\|\|\s*(https?:\/\/.*?)\s*$/', $line, $matches ) ) {
144144 $prefix = strtolower( $matches[1] );
145145 $url = $matches[2];
146 - if ( preg_match( '/(wikipedia|wiktionary|wikisource|wikiquote|wikibooks|wikimedia)\.org/', $url ) ) {
 146+ if ( preg_match( '/(wikipedia|wiktionary|wikisource|wikiquote|wikibooks|wikimedia|wikinews|wikiversity|wikimediafoundation|mediawiki)\.org/', $url ) ) {
147147 $local = 1;
148148 } else {
149149 $local = 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r982471.18wmf1: MFT r98246catrope20:11, 27 September 2011
r982481.17wmf1: MFT r98246catrope20:11, 27 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98242(bug 22407) Make [[mw:]] et al localcatrope20:04, 27 September 2011

Comments

#Comment by 😂 (talk | contribs)   20:27, 27 September 2011

I complained about that duplication some time ago...the amount of duplication between those two scripts is downright stupid.

Status & tagging log