r98222 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98221‎ | r98222 | r98223 >
Date:14:47, 27 September 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Per OverlordQ, fix for r87164: let's use an aggregate function that exists in postgresql
Modified paths:
  • /trunk/phase3/includes/WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WikiPage.php
——@@ -665,7 +665,7 @@
666666 if ( $dbr->implicitGroupby() ) {
667667 $realNameField = 'user_real_name';
668668 } else {
669 - $realNameField = 'FIRST(user_real_name) AS user_real_name';
 669+ $realNameField = 'MIN(user_real_name) AS user_real_name';
670670 }
671671
672672 $tables = array( 'revision', 'user' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r108767MFT to REL1_18 r98222...hashar22:09, 12 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87164Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry)ialex14:08, 30 April 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   19:20, 28 September 2011

If a hammer works... :)

Status & tagging log