r98220 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98219‎ | r98220 | r98221 >
Date:14:13, 27 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: Merge r90036 from 1.17wmf1, requested by Ariel
Modified paths:
  • /branches/wmf/1.18wmf1/includes/HistoryBlob.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/HistoryBlob.php
@@ -516,13 +516,17 @@
517517 $header = unpack( 'Vofp/Vcsize', substr( $diff, 0, 8 ) );
518518
519519 # Check the checksum if mhash is available
 520+ # TEMPORARY WMF PATCH -- temporarily disable hash check, since a large number of
 521+ # revisions appear to have hash mismatches
 522+ /*
520523 if ( extension_loaded( 'mhash' ) ) {
521524 $ofp = mhash( MHASH_ADLER32, $base );
522525 if ( $ofp !== substr( $diff, 0, 4 ) ) {
523526 wfDebug( __METHOD__. ": incorrect base checksum\n" );
524527 return false;
525528 }
526 - }
 529+ }*/
 530+ #### END WMF PATCH
527531 if ( $header['csize'] != strlen( $base ) ) {
528532 wfDebug( __METHOD__. ": incorrect base length\n" );
529533 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90036Reverted r89927 and applied a more appropriate fix for the reported hash mism...tstarling06:10, 14 June 2011

Status & tagging log