r89927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89926‎ | r89927 | r89928 >
Date:12:29, 12 June 2011
Author:ariel
Status:reverted
Tags:
Comment:
mft r89925 so we can disable mhash in php.ini instead of at build time
Modified paths:
  • /branches/wmf/1.17wmf1/includes/HistoryBlob.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/HistoryBlob.php
@@ -453,7 +453,7 @@
454454 $header = unpack( 'Vofp/Vcsize', substr( $diff, 0, 8 ) );
455455
456456 # Check the checksum if mhash is available
457 - if ( extension_loaded( 'mhash' ) ) {
 457+ if ( function_exists( 'mhash' ) ) {
458458 $ofp = mhash( MHASH_ADLER32, $base );
459459 if ( $ofp !== substr( $diff, 0, 4 ) ) {
460460 wfDebug( __METHOD__. ": incorrect base checksum\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r90036Reverted r89927 and applied a more appropriate fix for the reported hash mism...tstarling06:10, 14 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89925safer check if mhash is available (and I'm about to make it unavailable by di...ariel12:02, 12 June 2011

Status & tagging log