r98183 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98182‎ | r98183 | r98184 >
Date:22:09, 26 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r98148;
Modified paths:
  • /trunk/extensions/Contest/Contest.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.sql
@@ -3,7 +3,7 @@
44 -- Author: Jeroen De Dauw < jeroendedauw@gmail.com >
55
66 -- Contests
7 -CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/contests (
 7+CREATE TABLE IF NOT EXISTS /*_*/contests (
88 contest_id SMALLINT unsigned NOT NULL auto_increment PRIMARY KEY,
99 contest_name VARCHAR(255) NOT NULL, -- String indentifier for the contest
1010 contest_status TINYINT unsigned NOT NULL default '0', -- Status of the contest
@@ -11,8 +11,8 @@
1212 ) /*$wgDBTableOptions*/;
1313
1414 -- Contestants
15 -CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/contest_contestants (
16 - contestant_id INT(10) unsigned NOT NULL auto_increment PRIMARY KEY, -- Contestant id (unique id per user per contest)
 15+CREATE TABLE IF NOT EXISTS /*_*/contest_contestants (
 16+ contestant_id INT unsigned NOT NULL auto_increment PRIMARY KEY, -- Contestant id (unique id per user per contest)
1717 contestant_contest_id SMALLINT unsigned NOT NULL, -- Foreign key on contests.contest_id
1818 contestant_user_id INT(10) unsigned NOT NULL, -- Foreign key on user.user_id
1919
@@ -27,18 +27,18 @@
2828 ) /*$wgDBTableOptions*/;
2929
3030 -- Judge votes
31 -CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/contest_votes (
32 - vote_id INT(10) unsigned NOT NULL auto_increment PRIMARY KEY,
33 - vote_contestant_id INT(10) unsigned NOT NULL, -- Foreign key on contest_contestants.contestant_id
 31+CREATE TABLE IF NOT EXISTS /*_*/contest_votes (
 32+ vote_id INT unsigned NOT NULL auto_increment PRIMARY KEY,
 33+ vote_contestant_id INT unsigned NOT NULL, -- Foreign key on contest_contestants.contestant_id
3434 vote_user_id INT(10) unsigned NOT NULL, -- Judge user id
3535 vote_value SMALLINT NOT NULL -- The value of the vote
3636 ) /*$wgDBTableOptions*/;
3737
3838 -- Judge comments
39 -CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/contest_comments (
40 - comment_id INT(10) unsigned NOT NULL auto_increment PRIMARY KEY,
41 - comment_contestant_id INT(10) unsigned NOT NULL, -- Foreign key on contest_contestants.contestant_id
 39+CREATE TABLE IF NOT EXISTS /*_*/contest_comments (
 40+ comment_id INT unsigned NOT NULL auto_increment PRIMARY KEY,
 41+ comment_contestant_id INT unsigned NOT NULL, -- Foreign key on contest_contestants.contestant_id
4242 comment_user_id INT(10) unsigned NOT NULL, -- Judge user id
4343 comment_text TEXT NOT NULL, -- The comment text
44 - comment_time CHAR(14) binary NOT NULL default '' -- The time at which the comment was made
 44+ comment_time binary(14) binary NOT NULL default '' -- The time at which the comment was made
4545 ) /*$wgDBTableOptions*/;
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r98226follow up to r98183 - having binary or varbinary gives an error when I run up...jeroendedauw16:02, 27 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98148work on schemajeroendedauw17:59, 26 September 2011

Status & tagging log