r98135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98134‎ | r98135 | r98136 >
Date:15:12, 26 September 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Converted display part of new user log to new system
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1738,11 +1738,6 @@
17391739 'newuserlog' => array(
17401740 'newuserlogpage',
17411741 'newuserlogpagetext',
1742 - 'newuserlogentry',
1743 - 'newuserlog-byemail',
1744 - 'newuserlog-create-entry',
1745 - 'newuserlog-create2-entry',
1746 - 'newuserlog-autocreate-entry',
17471742 ),
17481743 'listgrouprights' => array(
17491744 'listgrouprights',
@@ -3524,6 +3519,11 @@
35253520 'logentry-move-move_redir-noredirect',
35263521 'logentry-patrol-patrol',
35273522 'logentry-patrol-patrol-auto',
 3523+ 'logentry-newusers-newusers',
 3524+ 'logentry-newusers-create',
 3525+ 'logentry-newusers-create2',
 3526+ 'logentry-newusers-autocreate',
 3527+ 'newuserlog-byemail',
35283528 ),
35293529 );
35303530
Index: trunk/phase3/includes/Setup.php
@@ -315,10 +315,8 @@
316316 $wgLogTypes[] = 'newusers';
317317 $wgLogNames['newusers'] = 'newuserlogpage';
318318 $wgLogHeaders['newusers'] = 'newuserlogpagetext';
319 - $wgLogActions['newusers/newusers'] = 'newuserlogentry'; // For compatibility with older log entries
320 - $wgLogActions['newusers/create'] = 'newuserlog-create-entry';
321 - $wgLogActions['newusers/create2'] = 'newuserlog-create2-entry';
322 - $wgLogActions['newusers/autocreate'] = 'newuserlog-autocreate-entry';
 319+ # newusers, create, create2, autocreate
 320+ $wgLogActionsHandlers['newusers/*'] = 'LogFormatter';
323321 }
324322
325323 if ( $wgCookieSecure === 'detect' ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2645,13 +2645,8 @@
26462646 'activeusers-noresult' => 'No users found.',
26472647
26482648 # Special:Log/newusers
2649 -'newuserlogpage' => 'User creation log',
2650 -'newuserlogpagetext' => 'This is a log of user creations.',
2651 -'newuserlogentry' => '', # do not translate or duplicate this message to other languages
2652 -'newuserlog-byemail' => 'password sent by e-mail',
2653 -'newuserlog-create-entry' => 'New user account',
2654 -'newuserlog-create2-entry' => 'created new account $1',
2655 -'newuserlog-autocreate-entry' => 'Account created automatically',
 2649+'newuserlogpage' => 'User creation log',
 2650+'newuserlogpagetext' => 'This is a log of user creations.',
26562651
26572652 # Special:ListGroupRights
26582653 'listgrouprights' => 'User group rights',
@@ -4658,5 +4653,10 @@
46594654 'logentry-move-move_redir-noredirect' => '$1 {{GENDER:$2|moved}} page $3 to $4 over a redirect without leaving a redirect',
46604655 'logentry-patrol-patrol' => '$1 {{GENDER:$2|marked}} revision $4 of page $3 patrolled',
46614656 'logentry-patrol-patrol-auto' => '$1 automatically {{GENDER:$2|marked}} revision $4 of page $3 patrolled',
 4657+'logentry-newusers-newusers' => '',
 4658+'logentry-newusers-create' => '$1 {{GENDER:$2|created}} a user account',
 4659+'logentry-newusers-create2' => '$1 {{GENDER:$2|created}} a user account $3',
 4660+'logentry-newusers-autocreate' => 'Account $1 was {{GENDER:$2|created}} automatically',
 4661+'newuserlog-byemail' => 'password sent by e-mail',
46624662
46634663 );

Sign-offs

UserFlagDate
Aaron Schulzinspected19:33, 26 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r98142Fix ignored message key (r98135)raymond16:00, 26 September 2011
r98365Followup r98135...nikerabbit20:28, 28 September 2011

Status & tagging log