r97940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97939‎ | r97940 | r97941 >
Date:17:59, 23 September 2011
Author:pgehres
Status:reverted (Comments)
Tags:
Comment:
Quick fix for RapidHTML bug
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html
@@ -35,7 +35,7 @@
3636 #step2wrapper, #step2header, #step3wrapper, #step3header { display: none; }
3737 #where-content { font-size: 13px; line-height: 19px; width: 325px; }
3838
39 - #amountErrorMessages, #billingErrorMessages, #paymentErrorMessages { color: #F00; }
 39+ #amtErrorMessages, #billingErrorMessages, #paymentErrorMessages { color: #F00; }
4040
4141 </style>
4242 <!--[if lt IE 7]><style>
@@ -73,7 +73,7 @@
7474
7575 <form method="post" name="paypalcontribution">
7676 <div id="step1wrapper">
77 - <div id="amountErrorMessages" class="small"></div>
 77+ <div id="amtErrorMessages" class="small"></div>
7878 <table id="amount-table-white">
7979 <tr>
8080 <td><label><input type="radio" name="amountRadio" value="5" /> $5</label></td>
@@ -85,7 +85,7 @@
8686 <td><label><input type="radio" name="amountRadio" value="50" /> $50</label></td>
8787 <td><label><input type="radio" name="amountRadio" value="100" /> $100</label></td>
8888 <td><label><input type="radio" name="amountRadio" value="250" /> $250</label></td>
89 - <td><input type="radio" name="amountRadio" id="input_amount_other" value="other" /> <label>$<input type="text" class="txt-sm hint" name="amountGiven" size="4" id="other-amount" title="Other..." onfocus="this.form.input_amount_other.checked=true;"/></label></td>
 89+ <td><label><input type="radio" name="amountRadio" id="input_amount_other" value="other" /> $<input type="text" class="txt-sm hint" name="amountGiven" size="4" id="other-amount" title="Other..." onfocus="this.form.input_amount_other.checked=true;"/></label></td>
9090 </tr>
9191 </table>
9292
@@ -272,7 +272,7 @@
273273 // show the errors
274274 var prevError = false;
275275 if( amountErrorString != ""){
276 - $("#amountErrorMessages").html( amountErrorString );
 276+ $("#amtErrorMessages").html( amountErrorString );
277277 prevError = true;
278278 showStep2(); // init the headers
279279 showStep3();

Follow-up revisions

RevisionCommit summaryAuthorDate
r97942Reverting r97940, clobbers fix from r97928awjrichards18:03, 23 September 2011

Comments

#Comment by Awjrichards (talk | contribs)   18:01, 23 September 2011

This clobbers the fix in r97928, reverting.

#Comment by Pgehres (WMF) (talk | contribs)   18:04, 23 September 2011

My apologies in the heat of battle.

Status & tagging log